From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform Date: Tue, 28 Jul 2015 20:14:55 +1000 Message-ID: <1438078495.7562.135.camel@kernel.crashing.org> References: <1437801670-23705-1-git-send-email-hegdevasant@linux.vnet.ibm.com> <1437801670-23705-4-git-send-email-hegdevasant@linux.vnet.ibm.com> <55B5540B.1000301@gmail.com> <55B5A853.3080909@linux.vnet.ibm.com> <55B72369.5040102@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:47491 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933236AbbG1KPe (ORCPT ); Tue, 28 Jul 2015 06:15:34 -0400 In-Reply-To: <55B72369.5040102@gmail.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: Vasant Hegde , linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, j.anaszewski@samsung.com, mpe@ellerman.id.au, rpurdie@rpsys.net, cooloney@gmail.com, khandual@linux.vnet.ibm.com, j.anaszewski81@gmail.com, arnd@arndb.de, stewart@linux.vnet.ibm.com On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote: > >>> + /* Register the classdev */ > >>> + rc = devm_led_classdev_register(dev, &powernv_led->cdev); > >>> + if (rc) { > >>> + dev_err(dev, "%s: Classdev registration failed for %s\n", > >>> + __func__, powernv_led->cdev.name); > >>> + } > > Braces are not needed here, Putting my old maintainer hat on for a minute ... this is serious nit picking :-) Arguably, the function being multi-line, the braces do make the code more readable. This is a matter of taste which in such as case which isn't a blatant violation of an important rule should be left to the choice of the code implementor/maintainer. Cheers, Ben.