From: Evan McClain <aeroevan@gmail.com>
To: Simon Que <sque@chromium.org>, Bryan Wu <cooloney@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>
Cc: linux-leds@vger.kernel.org, Sameer Nanda <snanda@chromium.org>,
Todd Broch <tbroch@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>
Subject: Re: [PATCH] leds: Add driver for Chrome OS keyboard LEDs
Date: Sat, 09 Jan 2016 14:38:25 -0500 [thread overview]
Message-ID: <1452368305.17442.7.camel@gmail.com> (raw)
In-Reply-To: <1452282543-10884-1-git-send-email-sque@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
On Fri, 2016-01-08 at 11:49 -0800, Simon Que wrote:
> Some Chrome OS devices use ACPI-based keyboard backlight LEDs.
>
> Signed-off-by: Simon Que <sque@chromium.org>
> ---
> drivers/leds/Kconfig | 7 +++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-chromeos-keyboard.c | 115
> ++++++++++++++++++++++++++++++++++
> 3 files changed, 123 insertions(+)
> create mode 100644 drivers/leds/leds-chromeos-keyboard.c
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 72156c1..4b64e80 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -5,6 +5,13 @@ config LEDS_GPIO_REGISTER
> As this function is used by arch code it must not be
> compiled as a
> module.
>
> +config LEDS_CHROMEOS_KEYBOARD
> + tristate "LED support for Chrome OS keyboards"
> + depends on LEDS_CLASS && ACPI
> + help
> + This option enables support for the LEDs on Chrome OS
> keyboards.
> + Say Y to enable keyboard LEDs on Chrome OS systems.
> +
> menuconfig NEW_LEDS
> bool "LED Support"
> help
This config option should be in the NEW_LEDS menu.
And it probably shouldn't get merged until:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/85142
c8507ec367b2283ad2398aa7fc6d8ec1765
is also submitted.
Thanks
--
Evan McClain
https://keybase.io/aeroevan
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-09 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 19:49 [PATCH] leds: Add driver for Chrome OS keyboard LEDs Simon Que
2016-01-09 19:38 ` Evan McClain [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-08 19:39 Simon Que
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452368305.17442.7.camel@gmail.com \
--to=aeroevan@gmail.com \
--cc=cooloney@gmail.com \
--cc=dlaurie@chromium.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=snanda@chromium.org \
--cc=sque@chromium.org \
--cc=tbroch@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).