From: Evan McClain <aeroevan@gmail.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, Simon Que <sque@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>
Subject: Re: [PATCH] leds: Add Chrome OS keyboard LEDs driver
Date: Tue, 23 Feb 2016 07:21:46 -0500 [thread overview]
Message-ID: <1456230106.20438.2.camel@gmail.com> (raw)
In-Reply-To: <56CC1BC7.9000108@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Tue, 2016-02-23 at 09:43 +0100, Jacek Anaszewski wrote:
> On 02/22/2016 05:00 PM, Evan McClain wrote:
> > +static int keyboard_led_remove(struct platform_device *pdev)
> > +{
> > + struct led_classdev *cdev = platform_get_drvdata(pdev);
> > +
> > + platform_set_drvdata(pdev, NULL);
>
> Empty line here please.
Unless I'm reading things wrong, I don't think keyboard_led_remove is
needed at all.
--
Evan McClain
https://keybase.io/aeroevan
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-23 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 16:00 [PATCH] leds: Add Chrome OS keyboard LEDs driver Evan McClain
2016-02-23 8:18 ` Jacek Anaszewski
2016-02-23 8:43 ` Jacek Anaszewski
2016-02-23 12:21 ` Evan McClain [this message]
2016-02-23 12:50 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456230106.20438.2.camel@gmail.com \
--to=aeroevan@gmail.com \
--cc=dlaurie@chromium.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).