From: Stefan Mavrodiev <stefan@olimex.com>
To: linux-sunxi@googlegroups.com,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <mripard@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-sunxi] Re: [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet
Date: Mon, 24 Feb 2020 08:31:06 +0200 [thread overview]
Message-ID: <1464324b-2b69-c20e-4af8-f32ae5451ea6@olimex.com> (raw)
In-Reply-To: <20200223133517.hfqrg5dta2xk4zj3@core.my.home>
On 2/23/20 3:35 PM, Ondřej Jirman wrote:
> On Sun, Feb 23, 2020 at 02:27:30PM +0100, megous hlavni wrote:
>> On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote:
>>> The tablet has a charger LED exposed on the top. This LED is controlled
>>> by AXP813 PMIC. Add support for enabling the LED and using it either
>>> for charging indication (handled by PMIC automatically) or for other uses
>>> via user control.
>> Dang, I just noticed someone sent a similar driver recently, although I had this
>> one prepared for quite some time (since 2017) in my tree. I guess I should have
>> sent it earlier.
>>
>> Please ignore.
> Though the meaning of "recently" is a bit relative. The other work was sent in
> a year ago. Here's a reference:
>
> https://lore.kernel.org/patchwork/cover/1042764/
Hi,
I'm the author of the 'other' work. I don't know the full story here,
but I don't
mind someone else submitting this patch as his.
When I submitted the last patch, there was the proposal to use the
ledtrig-pattern instead
of sysfs entries. Also AXP209 has inverted CTRL bit.
Please read the the 'other' discussion.
Best regards,
Stefan Mavrodiev
>
>> regards,
>> o.
>>
>>
>>> Please take a look.
>>>
>>> thank you and regards,
>>> Ondrej Jirman
>>>
>>> Ondrej Jirman (4):
>>> dt-bindings: leds: Add a binding for AXP813 charger led
>>> leds: axp20x: Support charger LED on AXP20x like PMICs
>>> ARM: dts: axp813: Add charger LED
>>> ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED
>>>
>>> .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++
>>> arch/arm/boot/dts/axp81x.dtsi | 5 +
>>> arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 +
>>> drivers/leds/Kconfig | 7 +
>>> drivers/leds/Makefile | 1 +
>>> drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++
>>> drivers/mfd/axp20x.c | 3 +
>>> 7 files changed, 284 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml
>>> create mode 100644 drivers/leds/leds-axp20x.c
>>>
>>> --
>>> 2.25.1
>>>
next prev parent reply other threads:[~2020-02-24 6:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 13:14 [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Ondrej Jirman
2020-02-23 13:14 ` [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led Ondrej Jirman
2020-02-25 12:55 ` Dan Murphy
2020-02-26 22:30 ` Rob Herring
2020-02-23 13:14 ` [PATCH 2/4] leds: axp20x: Support charger LED on AXP20x like PMICs Ondrej Jirman
2020-02-25 12:53 ` Dan Murphy
2020-02-26 14:08 ` Pavel Machek
2020-02-23 13:14 ` [PATCH 3/4] ARM: dts: axp813: Add charger LED Ondrej Jirman
2020-02-25 12:56 ` Dan Murphy
2020-02-23 13:14 ` [PATCH 4/4] ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED Ondrej Jirman
2020-02-23 13:27 ` [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Ondřej Jirman
2020-02-23 13:35 ` Ondřej Jirman
2020-02-24 6:31 ` Stefan Mavrodiev [this message]
2020-02-24 16:28 ` [linux-sunxi] " Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464324b-2b69-c20e-4af8-f32ae5451ea6@olimex.com \
--to=stefan@olimex.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).