From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH] leds: leds-gpio: Set of_node for created LED devices Date: Fri, 8 Jul 2016 14:53:38 +0200 Message-ID: <1467982420-15718-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:34109 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754876AbcGHMyF (ORCPT ); Fri, 8 Jul 2016 08:54:05 -0400 Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Richard Purdie , Jacek Anaszewski Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , "open list:LED SUBSYSTEM" , open list When working with Device Tree we iterate over children of "gpio-leds" compatible node and create LED device for each of them. We take care of all common DT properties (label, default trigger, state, etc.), however some triggers may want to support more of them. It could be useful for timer trigger to support setting delay on/off values with Device Tree property. Or for transient trigger to support e.g. duration property. We obviously should handle such properties in triggers, not in generic code. To let trigger drivers read properties from DT node we need to se= t of_node to point the relevant node. This change allows using all kind o= f of helpers in e.g. "activate" callbacks. Signed-off-by: Rafa=C5=82 Mi=C5=82ecki --- drivers/leds/leds-gpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 8229f06..9b991d4 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -165,6 +165,7 @@ static struct gpio_leds_priv *gpio_leds_create(stru= ct platform_device *pdev) return ERR_PTR(-ENOMEM); =20 device_for_each_child_node(dev, child) { + struct gpio_led_data *led_dat =3D &priv->leds[priv->num_leds]; struct gpio_led led =3D {}; const char *state =3D NULL; =20 @@ -205,12 +206,12 @@ static struct gpio_leds_priv *gpio_leds_create(st= ruct platform_device *pdev) if (fwnode_property_present(child, "panic-indicator")) led.panic_indicator =3D 1; =20 - ret =3D create_gpio_led(&led, &priv->leds[priv->num_leds], - dev, NULL); + ret =3D create_gpio_led(&led, led_dat, dev, NULL); if (ret < 0) { fwnode_handle_put(child); goto err; } + led_dat->cdev.dev->of_node =3D np; priv->num_leds++; } =20 --=20 1.8.4.5