Linux LED subsystem development
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: jacek.anaszewski@gmail.com
Cc: rpurdie@rpsys.net, pavel@ucw.cz, linux@arm.linux.org.uk,
	linux-leds@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>
Subject: [PATCH] leds: pwm: Allow changing the pinctrl state
Date: Fri, 17 Nov 2017 12:32:06 -0200	[thread overview]
Message-ID: <1510929126-9813-1-git-send-email-festevam@gmail.com> (raw)

From: Fabio Estevam <fabio.estevam@nxp.com>

Add suspend/resume pm hooks, so that the pinctrl state could be changed.

The motivation for doing this was to solve a problem on a imx6-cubox-i
board, where there is a GPIO controlled via pwm-leds that keeps turned on
when the system goes into suspend. Such behaviour is not what we expect
from a system going into suspend.

In order to solve this problem add the suspend/resume pm hooks where
the pinctrl state can be changed accordingly.

This allows to add an extra 'sleep' entry into the pinctrl node, where
the pinctrl can be changed from PWM to GPIO and pull up/pull down can be
configured to turn off the LED during suspend mode.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/leds/leds-pwm.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 8d456dc6..ff21aa2 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -14,6 +14,7 @@
 
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/of_platform.h>
 #include <linux/fb.h>
@@ -210,6 +211,20 @@ static int led_pwm_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static int __maybe_unused led_pwm_suspend(struct device *dev)
+{
+	return pinctrl_pm_select_sleep_state(dev);
+}
+
+static int __maybe_unused led_pwm_resume(struct device *dev)
+{
+	return pinctrl_pm_select_default_state(dev);
+}
+
+static const struct dev_pm_ops led_pwm_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(led_pwm_suspend, led_pwm_resume)
+};
+
 static const struct of_device_id of_pwm_leds_match[] = {
 	{ .compatible = "pwm-leds", },
 	{},
@@ -222,6 +237,7 @@ static struct platform_driver led_pwm_driver = {
 	.driver		= {
 		.name	= "leds_pwm",
 		.of_match_table = of_pwm_leds_match,
+		.pm = &led_pwm_pm_ops,
 	},
 };
 
-- 
2.7.4

             reply	other threads:[~2017-11-17 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 14:32 Fabio Estevam [this message]
2017-11-17 20:51 ` [PATCH] leds: pwm: Allow changing the pinctrl state Jacek Anaszewski
2017-11-17 21:34   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510929126-9813-1-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox