From: Ben Whitten <ben.whitten@gmail.com>
To: rpurdie@rpsys.net, pavel@ucw.cz, jacek.anaszewski@gmail.com
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Ben Whitten <ben.whitten@gmail.com>
Subject: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger
Date: Tue, 5 Dec 2017 11:19:10 +0000 [thread overview]
Message-ID: <1512472751-10928-1-git-send-email-ben.whitten@lairdtech.com> (raw)
From: Ben Whitten <ben.whitten@gmail.com>
The patch was converted to led_blink_oneshot, in doing so we find that the
behaviour has changed. As I dont want to break 'userspace' led behaviour this
patch shouldn't be merged as is. Open to suggestions.
Given an interval of 50ms and heavy throughput, the previous implementation
produced a blink with 100ms period and 50% dutycycle. The led_blink_oneshot
version produces a blink with 140ms period and 57% dutycycle.
I assume a fudge factor on the oneshot delay to bring the period back to 100ms
would be device specific so not suitable.
Kind regards,
Ben Whitten (1):
leds: trigger: Introduce a NETDEV trigger
.../ABI/testing/sysfs-class-led-trigger-netdev | 45 ++
drivers/leds/trigger/Kconfig | 7 +
drivers/leds/trigger/Makefile | 1 +
drivers/leds/trigger/ledtrig-netdev.c | 507 +++++++++++++++++++++
4 files changed, 560 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-netdev
create mode 100644 drivers/leds/trigger/ledtrig-netdev.c
--
2.7.4
next reply other threads:[~2017-12-05 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 11:19 Ben Whitten [this message]
2017-12-05 11:19 ` [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger Ben Whitten
2017-12-05 20:38 ` Jacek Anaszewski
2017-12-06 20:07 ` Ben Whitten
2017-12-07 11:35 ` Ben Whitten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512472751-10928-1-git-send-email-ben.whitten@lairdtech.com \
--to=ben.whitten@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).