From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Matthieu CASTET <matthieu.castet@parrot.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0
Date: Wed, 07 Mar 2018 15:32:23 +0000 [thread overview]
Message-ID: <1520436743.23626.33.camel@codethink.co.uk> (raw)
In-Reply-To: <20180302084437.007951262@linuxfoundation.org>
On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me
> know.
>
> ------------------
>
> From: Matthieu CASTET <matthieu.castet@parrot.com>
>
>
> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ]
>
> With the current code, the following sequence won't work :
> echo timer > trigger
>
> echo 0 > delay_off
> * at this point we call
> ** led_delay_off_store
> ** led_blink_set
[...]
The commit message got cut truncated here, which resulted in addresses
being omitted when it was sent out for review. The upstream commit
message refers to a LED_BLINK_SW flag which is not used in 4.4. So
this fix probably isn't needed, though I can't tell whether it does any
harm.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
next parent reply other threads:[~2018-03-07 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180302084435.842679610@linuxfoundation.org>
[not found] ` <20180302084437.007951262@linuxfoundation.org>
2018-03-07 15:32 ` Ben Hutchings [this message]
2018-03-07 20:39 ` [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0 Jacek Anaszewski
2018-03-08 17:24 ` Greg Kroah-Hartman
2018-03-08 18:04 ` Pavel Machek
2018-03-08 20:48 ` Jacek Anaszewski
2018-03-09 1:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520436743.23626.33.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=matthieu.castet@parrot.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).