From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9452C6FD1F for ; Wed, 22 Mar 2023 17:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbjCVRYj (ORCPT ); Wed, 22 Mar 2023 13:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbjCVRYY (ORCPT ); Wed, 22 Mar 2023 13:24:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 531E567725 for ; Wed, 22 Mar 2023 10:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679505744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LRXVzF++MrVMIkJs3jZDHeZ/HQCwH6dYetSm4Auni4U=; b=MdgAJx3Wd9SrnkY9/IM7cSGxQ3F276RKsOH7mRDI6Rbqd1mhi3LTyUgU0Q0wcoveW31JcC vty4Hj8LumanDZge48fWMPT5JRoeyhJK5goq9XX2Sn3bLN0nh75DH3/Odi45/eftv9ZxgK UYad/6puT7fKuGb6rZIewZOZ6jgAXio= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-iPHKlrCGMwu4FvsTfCbNIQ-1; Wed, 22 Mar 2023 13:22:22 -0400 X-MC-Unique: iPHKlrCGMwu4FvsTfCbNIQ-1 Received: by mail-ed1-f69.google.com with SMTP id es16-20020a056402381000b004fa3e04c882so27997792edb.10 for ; Wed, 22 Mar 2023 10:22:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679505741; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LRXVzF++MrVMIkJs3jZDHeZ/HQCwH6dYetSm4Auni4U=; b=n0/2XCH6FEqkVp+ml8dbaMYIRz9YVOuCtDgua9pG4HtUFbXOSSdaJ3KOVm3HZzRY54 4MVaLdoKnPtelsurUShNArOPuUNQ+d5toeXI+GWrUmEh7zaeDcVvxhu7z7JZ8762QFpQ dIRIvdJ7M2h/j9yOSDKSuP54818OcDQlHaKdf+HhQpYu+5Imw8tL9bOfLwNBbL6dNzxu KdgKWqJOuuk/DkEnyduZdxOCXDJtPH7aC4HyFJZrkYpZRLwrXfDzDDdl/eqc9SiptPFR fGHu8sQkw6/c+uT4rqOfRKAa+irl3rULgtWloJ2bvA1mxN0w+538PwGDZhfMZ2tBRudW rJ9Q== X-Gm-Message-State: AO0yUKUklsJ3Q1HVJo8mFyRNjMi4oERffOitCmB8C/h6P+igqcg7eTCA 2oR1k1zm1L4W9/NrTQepttGldUnCjzAogmneOju5PWuK+ULqu0q6RzYcxN95256J/sv4vjJJRKR F2b9BnGFIzonaTGn+990pjQ== X-Received: by 2002:a17:906:46ce:b0:931:ad32:79ed with SMTP id k14-20020a17090646ce00b00931ad3279edmr8131239ejs.12.1679505741544; Wed, 22 Mar 2023 10:22:21 -0700 (PDT) X-Google-Smtp-Source: AK7set8xtI18BKS9k7p/pa5yo7CxtqKHem/X/Gy85iArc5emZqyws6miH9/u9bwflD3rZSCFexAEoQ== X-Received: by 2002:a17:906:46ce:b0:931:ad32:79ed with SMTP id k14-20020a17090646ce00b00931ad3279edmr8131213ejs.12.1679505741212; Wed, 22 Mar 2023 10:22:21 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id t21-20020a50d715000000b004af7191fe35sm8042388edi.22.2023.03.22.10.22.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 10:22:20 -0700 (PDT) Message-ID: <15dfc66b-83f7-4abf-1bc3-3bd9a2666aa1@redhat.com> Date: Wed, 22 Mar 2023 18:22:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 5/8] leds: tps68470: Refactor tps68470_brightness_get() Content-Language: en-US, nl To: Daniel Scally , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: pavel@ucw.cz, lee@kernel.org, markgross@kernel.org, sboyd@kernel.org, hpa@redhat.com References: <20230322160926.948687-1-dan.scally@ideasonboard.com> <20230322160926.948687-6-dan.scally@ideasonboard.com> From: Hans de Goede In-Reply-To: <20230322160926.948687-6-dan.scally@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi, On 3/22/23 17:09, Daniel Scally wrote: > We want to extend tps68470_brightness_get() to be usable with the > other LEDs supplied by the IC; refactor it to make that easier. > > Signed-off-by: Daniel Scally > --- > drivers/leds/leds-tps68470.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/leds/leds-tps68470.c b/drivers/leds/leds-tps68470.c > index d2060fe4259d..44df175d25de 100644 > --- a/drivers/leds/leds-tps68470.c > +++ b/drivers/leds/leds-tps68470.c > @@ -77,23 +77,24 @@ static enum led_brightness tps68470_brightness_get(struct led_classdev *led_cdev > int ret = 0; > int value = 0; > > - ret = regmap_read(regmap, TPS68470_REG_ILEDCTL, &value); > - if (ret) > - return dev_err_probe(led_cdev->dev, -EINVAL, "failed on reading register\n"); > - > switch (led->led_id) { > case TPS68470_ILED_A: > - value = value & TPS68470_ILEDCTL_ENA; > - break; > case TPS68470_ILED_B: > - value = value & TPS68470_ILEDCTL_ENB; > + ret = regmap_read(regmap, TPS68470_REG_ILEDCTL, &value); > + if (ret) > + return dev_err_probe(led_cdev->dev, ret, > + "failed to read LED status\n"); I realize this is a pre-existing problem, but I don't think we should be using dev_err_probe() in functions which are used outside the probe() path? So maybe fix this up while at it and make this: if (ret) { dev_err(led_cdev->dev, ""failed to read LED status: %d\n", ret); return ret; } > + > + value &= led->led_id == TPS68470_ILED_A ? TPS68470_ILEDCTL_ENA : > + TPS68470_ILEDCTL_ENB; > break; > + default: > + return dev_err_probe(led_cdev->dev, -EINVAL, "invalid LED ID\n"); idem. With those fixed: Reviewed-by: Hans de Goede Regards, Hans > } > > return value ? LED_ON : LED_OFF; > } > > - > static int tps68470_ledb_current_init(struct platform_device *pdev, > struct tps68470_device *tps68470) > {