From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>
Cc: "Fabio Estevam" <festevam@gmail.com>,
devicetree@vger.kernel.org,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
"Michal Vokáč" <michal.vokac@ysoft.com>,
stable@vger.kernel.org
Subject: [RFC 1/2] dt-bindings: leds: Add color as a required property for lp55xx controller
Date: Fri, 14 May 2021 16:44:36 +0200 [thread overview]
Message-ID: <1621003477-11250-2-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com>
Since addition of the multicolor LED framework in commit 92a81562e695
("leds: lp55xx: Add multicolor framework support to lp55xx") the color
property becomes required even if the multicolor framework is not enabled
and used.
Fix the binding documentation to reflect the real state.
Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
Cc: <stable@vger.kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
index f552cd143d5b..e6bdd1cb615a 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
@@ -101,6 +101,7 @@ patternProperties:
description: name of channel
required:
+ - color
- compatible
- reg
@@ -127,6 +128,7 @@ examples:
chan-name = "d1";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_RED>;
};
led@1 {
@@ -134,6 +136,7 @@ examples:
chan-name = "d2";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_BLUE>;
};
led@2 {
@@ -141,6 +144,7 @@ examples:
chan-name = "d3";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_GREEN>;
};
led@3 {
@@ -148,6 +152,7 @@ examples:
chan-name = "d4";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_RED>;
};
led@4 {
@@ -155,6 +160,7 @@ examples:
chan-name = "d5";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_BLUE>;
};
led@5 {
@@ -162,6 +168,7 @@ examples:
chan-name = "d6";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_GREEN>;
};
led@6 {
@@ -169,6 +176,7 @@ examples:
chan-name = "d7";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_RED>;
};
led@7 {
@@ -176,6 +184,7 @@ examples:
chan-name = "d8";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_BLUE>;
};
led@8 {
@@ -183,6 +192,7 @@ examples:
chan-name = "d9";
led-cur = /bits/ 8 <0x14>;
max-cur = /bits/ 8 <0x20>;
+ color = <LED_COLOR_ID_GREEN>;
};
};
--
2.7.4
next prev parent reply other threads:[~2021-05-14 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 14:44 [RFC 0/2] Regression in lp55xx driver since multicolor framework was added? Michal Vokáč
2021-05-14 14:44 ` Michal Vokáč [this message]
2021-05-17 2:27 ` [RFC 1/2] dt-bindings: leds: Add color as a required property for lp55xx controller Rob Herring
2021-05-14 14:44 ` [RFC 2/2] ARM: dts: imx6dl-yapp4: Fix lp5562 driver probe Michal Vokáč
2021-06-23 20:13 ` Pavel Machek
2021-06-24 7:54 ` Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621003477-11250-2-git-send-email-michal.vokac@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).