* [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency
@ 2025-06-20 11:43 Arnd Bergmann
2025-06-25 4:02 ` Randy Dunlap
2025-07-01 13:26 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-06-20 11:43 UTC (permalink / raw)
To: Lee Jones, Pavel Machek, Matthias Fend
Cc: Arnd Bergmann, André Apitzsch, linux-leds, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This driver can optionally use the v4l2_flash infrastructure, but fails to
link built=in if that is in a loadable module:
ld.lld-21: error: undefined symbol: v4l2_flash_release
>>> referenced by leds-tps6131x.c:792 (drivers/leds/flash/leds-tps6131x.c:792)
Add the usual Kconfig dependency for it, still allowing it to be built when
CONFIG_V4L2_FLASH_LED_CLASS is disabled.
Fixes: b338a2ae9b31 ("leds: tps6131x: Add support for Texas Instruments TPS6131X flash LED driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/flash/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
index 55ca663ca506..5e08102a6784 100644
--- a/drivers/leds/flash/Kconfig
+++ b/drivers/leds/flash/Kconfig
@@ -136,6 +136,7 @@ config LEDS_TPS6131X
tristate "LED support for TI TPS6131x flash LED driver"
depends on I2C && OF
depends on GPIOLIB
+ depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
select REGMAP_I2C
help
This option enables support for Texas Instruments TPS61310/TPS61311
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency
2025-06-20 11:43 [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency Arnd Bergmann
@ 2025-06-25 4:02 ` Randy Dunlap
2025-07-01 13:26 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2025-06-25 4:02 UTC (permalink / raw)
To: Arnd Bergmann, Lee Jones, Pavel Machek, Matthias Fend
Cc: Arnd Bergmann, André Apitzsch, linux-leds, linux-kernel
On 6/20/25 4:43 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver can optionally use the v4l2_flash infrastructure, but fails to
> link built=in if that is in a loadable module:
>
> ld.lld-21: error: undefined symbol: v4l2_flash_release
>>>> referenced by leds-tps6131x.c:792 (drivers/leds/flash/leds-tps6131x.c:792)
>
> Add the usual Kconfig dependency for it, still allowing it to be built when
> CONFIG_V4L2_FLASH_LED_CLASS is disabled.
>
> Fixes: b338a2ae9b31 ("leds: tps6131x: Add support for Texas Instruments TPS6131X flash LED driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I just made this same patch, so
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/leds/flash/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
> index 55ca663ca506..5e08102a6784 100644
> --- a/drivers/leds/flash/Kconfig
> +++ b/drivers/leds/flash/Kconfig
> @@ -136,6 +136,7 @@ config LEDS_TPS6131X
> tristate "LED support for TI TPS6131x flash LED driver"
> depends on I2C && OF
> depends on GPIOLIB
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> select REGMAP_I2C
> help
> This option enables support for Texas Instruments TPS61310/TPS61311
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency
2025-06-20 11:43 [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency Arnd Bergmann
2025-06-25 4:02 ` Randy Dunlap
@ 2025-07-01 13:26 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2025-07-01 13:26 UTC (permalink / raw)
To: Lee Jones, Pavel Machek, Matthias Fend, Arnd Bergmann
Cc: Arnd Bergmann, André Apitzsch, linux-leds, linux-kernel
On Fri, 20 Jun 2025 13:43:58 +0200, Arnd Bergmann wrote:
> This driver can optionally use the v4l2_flash infrastructure, but fails to
> link built=in if that is in a loadable module:
>
> ld.lld-21: error: undefined symbol: v4l2_flash_release
> >>> referenced by leds-tps6131x.c:792 (drivers/leds/flash/leds-tps6131x.c:792)
>
> Add the usual Kconfig dependency for it, still allowing it to be built when
> CONFIG_V4L2_FLASH_LED_CLASS is disabled.
>
> [...]
Applied, thanks!
[1/1] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency
commit: c3c38e80016548685e439b23999b4f0bd0ad7e05
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-01 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 11:43 [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency Arnd Bergmann
2025-06-25 4:02 ` Randy Dunlap
2025-07-01 13:26 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).