From: Florian Fainelli <f.fainelli@gmail.com>
To: Zach Brown <zach.brown@ni.com>
Cc: mlindner@marvell.com, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
rpurdie@rpsys.net, j.anaszewski@samsung.com,
linux-leds@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change
Date: Mon, 10 Oct 2016 02:03:32 -0700 [thread overview]
Message-ID: <1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com> (raw)
In-Reply-To: <1475874897-29720-4-git-send-email-zach.brown@ni.com>
On 10/07/2016 02:14 PM, Zach Brown wrote:
> From: Josh Cartwright <josh.cartwright@ni.com>
>
> Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
> create a set of led triggers for each instantiated PHY device. There is
> one LED trigger per link-speed, per-phy.
>
> This allows for a user to configure their system to allow a set of LEDs
> to represent link state changes on the phy.
Seems like we are past the RFC state now, so you might want to prefix
your patches with [PATCH ..] now. Also, the typical prefix used for
PHYLIB changes is net: phy: foo
Other than that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Andrew, are you happy with this implementation?
[snip]
> +
> +#ifdef CONFIG_LED_TRIGGER_PHY
> +
> +#include <linux/leds.h>
> +#include <linux/phy.h>
> +
> +#define PHY_LINK_LED_MAX_TRIGGERS 5
> +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7
> +#define PHY_MII_BUS_ID_SIZE (20 - 3)
This particular constant may be something worth moving to
include/linux/phy.h eventually.
--
Florian
next prev parent reply other threads:[~2016-10-10 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 21:14 [PATCH 0/3] Add support for led triggers on phy link state change Zach Brown
2016-10-07 21:14 ` [RFC v3 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Zach Brown
2016-10-07 21:14 ` [RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown
2016-10-07 21:14 ` [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change Zach Brown
2016-10-10 9:03 ` Florian Fainelli [this message]
2016-10-11 20:56 ` Andrew Lunn
2016-10-12 15:57 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrew@lunn.ch \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=stephen@networkplumber.org \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).