From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>, Linus Walleij <linus.walleij@linaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
<linux-leds@vger.kernel.org>,
Vincent Donnefort <vdonnefort@gmail.com>,
Simon Guinot <simon.guinot@sequanux.org>
Subject: Re: [PATCH 1/2 v2] leds: ns2: Absorb platform data
Date: Thu, 27 Feb 2020 14:28:24 -0600 [thread overview]
Message-ID: <1f1b52dd-d702-efe3-cb62-bbf4ae67a25b@ti.com> (raw)
In-Reply-To: <20200226135006.GF4080@duo.ucw.cz>
Pavel
On 2/26/20 7:50 AM, Pavel Machek wrote:
> Hi!
>
>> Nothing in the kernel includes the external header
>> <linux/platform_data/leds-kirkwood-ns2.h> so just push the
>> contents into the ns2 leds driver. If someone wants to use
>> platform data or board files to describe this device they
>> should be able to do so using GPIO machine descriptors but
>> in any case device tree should be the way forward for these
>> systems in all cases I can think of, and the driver already
>> supports that.
>>
>> Cc: Vincent Donnefort <vdonnefort@gmail.com>
>> Tested-by: Simon Guinot <simon.guinot@sequanux.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> ChangeLog v1->v2:
>> - Collect Simon's Tested-by tag
> Aha, I applied v1, but collected tested-by tag manually, so we should
> be ok.
You took the wrong version of the patch set.
I had comments on v2 (you seemed to have ignored) and v3 was submitted.
Dan
next prev parent reply other threads:[~2020-02-27 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:13 [PATCH 1/2 v2] leds: ns2: Absorb platform data Linus Walleij
2020-02-10 10:13 ` [PATCH 2/2 v2] leds: ns2: Convert to GPIO descriptors Linus Walleij
2020-02-12 13:27 ` [PATCH 1/2 v2] leds: ns2: Absorb platform data Dan Murphy
2020-02-26 13:50 ` Pavel Machek
2020-02-27 20:28 ` Dan Murphy [this message]
2020-02-28 9:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f1b52dd-d702-efe3-cb62-bbf4ae67a25b@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=simon.guinot@sequanux.org \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox