From: Wolfram Sang <wsa@the-dreams.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Markos Chandras <markos.chandras@imgtec.com>,
linux-i2c@vger.kernel.org, Bryan Wu <cooloney@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols
Date: Tue, 3 Sep 2013 16:55:10 +0100 [thread overview]
Message-ID: <20130903155510.GA3156@katana> (raw)
In-Reply-To: <20130903145839.GA14258@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On Tue, Sep 03, 2013 at 04:58:39PM +0200, Ralf Baechle wrote:
> On Tue, Sep 03, 2013 at 03:27:00PM +0100, Markos Chandras wrote:
>
> > Select NEW_LEDS and LEDS_CLASS since they export symbols
> > needed by leds-sead3.c. Fixes the following build problem:
> >
> > leds-sead3.c:(.text+0xf0c): undefined
> > reference to `led_classdev_unregister'
> > leds-sead3.c:(.text+0xf18): undefined
> > reference to `led_classdev_unregister'
> >
> > Also select I2C since it's needed by sead3-pic32-i2c-drv.c
> > Fixes the following build problem:
> > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
> > implicit declaration of
> > function 'i2c_add_numbered_adapter'
>
> You probably should setup a bus like all the other callers of
> i2c_add_numbered_adapter() in drivers/i2c/busses/; similar for the LED
> issue.
The I2C driver should really be in the i2c realm AFAICS. Also, it needs
a few cleanups.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-09-03 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378218420-28011-1-git-send-email-markos.chandras@imgtec.com>
2013-09-03 14:58 ` [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols Ralf Baechle
2013-09-03 15:55 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903155510.GA3156@katana \
--to=wsa@the-dreams.de \
--cc=cooloney@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).