* Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols
[not found] <1378218420-28011-1-git-send-email-markos.chandras@imgtec.com>
@ 2013-09-03 14:58 ` Ralf Baechle
2013-09-03 15:55 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2013-09-03 14:58 UTC (permalink / raw)
To: Markos Chandras, Wolfram Sang, linux-i2c, Bryan Wu,
Richard Purdie, linux-leds
Cc: linux-mips
On Tue, Sep 03, 2013 at 03:27:00PM +0100, Markos Chandras wrote:
> Select NEW_LEDS and LEDS_CLASS since they export symbols
> needed by leds-sead3.c. Fixes the following build problem:
>
> leds-sead3.c:(.text+0xf0c): undefined
> reference to `led_classdev_unregister'
> leds-sead3.c:(.text+0xf18): undefined
> reference to `led_classdev_unregister'
>
> Also select I2C since it's needed by sead3-pic32-i2c-drv.c
> Fixes the following build problem:
> arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
> implicit declaration of
> function 'i2c_add_numbered_adapter'
You probably should setup a bus like all the other callers of
i2c_add_numbered_adapter() in drivers/i2c/busses/; similar for the LED
issue.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols
2013-09-03 14:58 ` [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols Ralf Baechle
@ 2013-09-03 15:55 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-09-03 15:55 UTC (permalink / raw)
To: Ralf Baechle
Cc: Markos Chandras, linux-i2c, Bryan Wu, Richard Purdie, linux-leds,
linux-mips
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On Tue, Sep 03, 2013 at 04:58:39PM +0200, Ralf Baechle wrote:
> On Tue, Sep 03, 2013 at 03:27:00PM +0100, Markos Chandras wrote:
>
> > Select NEW_LEDS and LEDS_CLASS since they export symbols
> > needed by leds-sead3.c. Fixes the following build problem:
> >
> > leds-sead3.c:(.text+0xf0c): undefined
> > reference to `led_classdev_unregister'
> > leds-sead3.c:(.text+0xf18): undefined
> > reference to `led_classdev_unregister'
> >
> > Also select I2C since it's needed by sead3-pic32-i2c-drv.c
> > Fixes the following build problem:
> > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
> > implicit declaration of
> > function 'i2c_add_numbered_adapter'
>
> You probably should setup a bus like all the other callers of
> i2c_add_numbered_adapter() in drivers/i2c/busses/; similar for the LED
> issue.
The I2C driver should really be in the i2c realm AFAICS. Also, it needs
a few cleanups.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-03 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1378218420-28011-1-git-send-email-markos.chandras@imgtec.com>
2013-09-03 14:58 ` [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols Ralf Baechle
2013-09-03 15:55 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).