From: Pavel Machek <pavel@ucw.cz>
To: Joe Xue <lgxue@hotmail.com>
Cc: "cooloney@gmail.com" <cooloney@gmail.com>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"rob@landley.net" <rob@landley.net>,
"milo.kim@ti.com" <milo.kim@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH] Add LED pattern trigger
Date: Tue, 31 Dec 2013 12:33:52 +0100 [thread overview]
Message-ID: <20131231113352.GA4233@amd.pavel.ucw.cz> (raw)
In-Reply-To: <BLU172-W18A7B97F4E688F416C5DABACC90@phx.gbl>
On Tue 2013-12-31 00:00:39, Joe Xue wrote:
> > What about something like this?
> >
> > Not shcheduling timer when nothing changed should save a bit of power/cpu...
> >
> > if (pattern_data->pattern[pattern_data->count] == '/') {
> > return;
> > }
> >
> > this = pattern_data->pattern[pattern_data->count]
> > if (this == '#')
> > new_brigtness = pattern_data->brightness_on;
> > if (this == ' ')
> > new_brigtness = LED_OFF;
> > repeat = 1;
> > while (pattern_data->pattern[pattern_data->count + repeat] == this)
> > repeat++;
> >
> > mod_timer(&pattern_data->timer,
> > jiffies + msecs_to_jiffies(pattern_data->delay_unit * repeat));
> >
> >
> Working on it.
>
> Thanks for your help.
You are welcome :-).
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-12-31 11:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 0:11 [PATCH] Add LED pattern trigger Joe Xue
2013-12-30 16:21 ` One Thousand Gnomes
2013-12-30 23:24 ` Joe Xue
2013-12-31 0:18 ` One Thousand Gnomes
2013-12-31 18:48 ` Joe Xue
2014-01-01 20:10 ` One Thousand Gnomes
2014-01-01 22:44 ` David Lang
2014-01-01 23:01 ` One Thousand Gnomes
2014-01-01 23:51 ` David Lang
2014-01-03 0:14 ` Bryan Wu
2014-01-03 9:33 ` Richard Weinberger
2014-01-03 15:23 ` One Thousand Gnomes
2014-01-05 22:23 ` n900 led compiler (was Re: [PATCH] Add LED pattern trigger) Pavel Machek
2014-01-07 15:40 ` Linus Walleij
2013-12-30 18:33 ` [PATCH] Add LED pattern trigger Pavel Machek
2013-12-31 5:00 ` Joe Xue
2013-12-31 11:33 ` Pavel Machek [this message]
2013-12-31 12:29 ` Richard Weinberger
2013-12-31 19:03 ` Pavel Machek
2014-01-01 20:11 ` One Thousand Gnomes
2014-01-01 2:57 ` [PATCH v2 1/1] leds: " Joe Xue
2014-01-01 3:03 ` [PATCH v2 1/1] " Joe Xue
2014-01-06 21:47 ` [PATCH v3 1/1] leds: " lgxue
2014-01-06 22:10 ` Joe Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231113352.GA4233@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=cooloney@gmail.com \
--cc=lgxue@hotmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=rob@landley.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).