From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Bryan Wu'" <cooloney@gmail.com>,
linux-leds@vger.kernel.org,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'Márton Németh'" <nm127@freemail.hu>,
"'Ondrej Zary'" <linux@rainbow-software.org>
Subject: Re: [PATCH 4/5] leds: clevo-mail: fix incorrect placement of __initdata marker
Date: Wed, 26 Feb 2014 09:30:37 +0100 [thread overview]
Message-ID: <20140226083037.GB6865@pengutronix.de> (raw)
In-Reply-To: <000e01cf32b1$ac754340$055fc9c0$%han@samsung.com>
Hello,
On Wed, Feb 26, 2014 at 02:14:49PM +0900, Jingoo Han wrote:
> diff --git a/drivers/leds/leds-clevo-mail.c b/drivers/leds/leds-clevo-mail.c
> index d93e245..5974810 100644
> --- a/drivers/leds/leds-clevo-mail.c
> +++ b/drivers/leds/leds-clevo-mail.c
> @@ -19,7 +19,7 @@ MODULE_AUTHOR("Márton Németh <nm127@freemail.hu>");
> MODULE_DESCRIPTION("Clevo mail LED driver");
> MODULE_LICENSE("GPL");
>
> -static bool __initdata nodetect;
> +static bool nodetect __initdata;
> module_param_named(nodetect, nodetect, bool, 0);
> MODULE_PARM_DESC(nodetect, "Skip DMI hardware detection");
not sure why I'm on Cc, but yes, the change is in line with gcc docs.
But I wonder if __initdata is ok for a variable backing a module
parameter as it appears in /sys. Does
cat /sys/module/leds-clevo-mail/parameters/nodetect
result in an oops? If yes, better drop the __initdata instead of moving
it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-02-26 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 5:09 [PATCH 1/5] leds: leds-ss4200: fix incorrect placement of __initdata marker Jingoo Han
2014-02-26 5:10 ` [PATCH 2/5] leds: leds-ss4200: remove DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2014-02-27 18:01 ` Bryan Wu
2014-02-26 5:11 ` [PATCH 3/5] leds: lp5562: remove unnecessary parentheses Jingoo Han
2014-02-27 18:03 ` Bryan Wu
2014-02-26 5:14 ` [PATCH 4/5] leds: clevo-mail: fix incorrect placement of __initdata marker Jingoo Han
2014-02-26 8:30 ` Uwe Kleine-König [this message]
2014-02-27 18:16 ` Bryan Wu
2014-02-26 5:16 ` [PATCH 5/5] leds: blinkm: remove unnecessary spaces Jingoo Han
2014-02-26 6:25 ` Jan-Simon Möller
2014-02-27 18:22 ` Bryan Wu
2014-02-27 18:00 ` [PATCH 1/5] leds: leds-ss4200: fix incorrect placement of __initdata marker Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226083037.GB6865@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=cooloney@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=nm127@freemail.hu \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).