From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Tue, 20 May 2014 08:06:44 +0100 Message-ID: <20140520070644.GB20874@lee--X1> References: <58de41a38511a107941d9c3b2cea314c0becfff7.1400258021.git.andreas.werner@men.de> <5377849E.7020001@roeck-us.net> <20140519124324.GB398@awelinux> <537A05D4.6080308@roeck-us.net> <20140519173953.GA20874@lee--X1> <20140520074748.GC398@awelinux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f179.google.com ([209.85.213.179]:34175 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbaETHGu (ORCPT ); Tue, 20 May 2014 03:06:50 -0400 Received: by mail-ig0-f179.google.com with SMTP id hn18so362062igb.0 for ; Tue, 20 May 2014 00:06:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140520074748.GC398@awelinux> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Andreas Werner Cc: Guenter Roeck , linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, johannes.thumshirn@men.de, thomas.schnuerer@men.de, wernerandy@gmx.de > > > Not my call to make; depends on the mfd maintainer. I would not a= ccept it, as I see it > > > as unnecessary, adding complexity, and pointless. Sure, you can a= lways find examples > > > for everything somewhere in the kernel, but that doesn't make it = better. > >=20 > > I'm inclined to agree with Guenter, this patch is just noise. >=20 > Ok no problem, i will fix it and resend the patch. > For now I know it for the future :-) >=20 > Any other comments about the patch series? If you submit a v2, I'll re-review the bits you leave in. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog