From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Werner Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Thu, 21 Aug 2014 15:57:08 +0200 Message-ID: <20140821135707.GA16867@awelinux> References: <20140821113046.GZ4266@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail1.bemta3.messagelabs.com ([195.245.230.177]:27038 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754229AbaHUNIr (ORCPT ); Thu, 21 Aug 2014 09:08:47 -0400 Content-Disposition: inline In-Reply-To: <20140821113046.GZ4266@lee--X1> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Lee Jones Cc: Andreas Werner , linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > On Wed, 13 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the = BMC. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikr= oelektronik > > and on a few Box/Display Computer. > >=20 > > Added MFD Core driver, supporting the I2C communication to the devi= ce. > >=20 > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > >=20 > > Signed-off-by: Andreas Werner > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++= ++++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > >=20 > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..bf155b9 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the function= ality > > of the device. > > =20 > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C=3Dy >=20 > Why must I2C be built-in? Sorry my mistake, I2C must not be built in. >=20 > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus= =2E > > + The device supports multiple sub-devices like LED, HWMON and W= DT. > > + This driver provides common support for accessing the devices; > > + additional drivers must be enabled in order to use the > > + functionality of the BMC device. > > + >=20 > Apart from that the patch looks good to me. >=20 > I'm assuming this can go in via the MFD tree by itself? Yes why not. Do you want to have a single patch for the MFD or is it better to wait for the other Subsystem maintainer that I=20 can resend a patch v5? Regards Andy >=20 > Acked-by: Lee Jones >=20 > --=20 > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog