From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v4 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver Date: Fri, 22 Aug 2014 02:04:43 -0700 Message-ID: <20140822090443.GB13483@roeck-us.net> References: <20140821184501.GC16045@roeck-us.net> <20140822083930.GB453@awelinux> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f179.google.com ([209.85.192.179]:40727 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbaHVJEs (ORCPT ); Fri, 22 Aug 2014 05:04:48 -0400 Content-Disposition: inline In-Reply-To: <20140822083930.GB453@awelinux> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, lee.jones@linaro.org, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, lm-sensors@lm-sensors.org On Fri, Aug 22, 2014 at 10:39:31AM +0200, Andreas Werner wrote: > On Thu, Aug 21, 2014 at 11:45:01AM -0700, Guenter Roeck wrote: > > On Wed, Aug 13, 2014 at 10:40:37AM +0200, Andreas Werner wrote: > > > Added driver to support the 14F021P00 BMC Hardware Monitoring. > > > The BMC is a Board Management Controller including monitoring of the > > > board voltages. > > > > > > Signed-off-by: Andreas Werner > > > --- > > > drivers/hwmon/Kconfig | 7 ++ > > > drivers/hwmon/Makefile | 1 + > > > drivers/hwmon/menf21bmc_hwmon.c | 238 ++++++++++++++++++++++++++++++++++++++++ > > > > Forgot: Please also provide Documentation/hwmon/menf21bmc. > > > > Did not know that i have to do it. > But you are right it is good to have one. > Documentation/hwmon/submitting-patches is quite useful. Thanks, Guenter