From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity Date: Fri, 22 Aug 2014 16:42:44 -0500 Message-ID: <20140822214244.GA25922@kroah.com> References: <1408708399-20423-1-git-send-email-sojka@merica.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:37103 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbaHVVn0 (ORCPT ); Fri, 22 Aug 2014 17:43:26 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Bryan Wu Cc: Michal Sojka , Linux LED Subsystem , michal.vokac@comap.cz, Richard Purdie , Felipe Balbi , lkml , linux-usb@vger.kernel.org On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote: > On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka wrote: > > With this patch, USB gadget activity can be signaled by blinking a LED. > > > > Since there is no generic code where to put the trigger for all USB > > controllers, each USB controller needs to call the trigger individually. > > This patch adds the call only for the musb controller where I can test > > it. > > > > Generally I think one led trigger for both USB host and USB gadget > activity is good enough. We don't need 2 same led trigger here. What about systems that have both running at the same time? Don't you want individual control? > And probably you can just put this code in drivers/usb subsystem, > since this driver is quite simple to add to USB subsystem. I have no objection to that, if the LED people don't mind it. thanks, greg k-h