From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v6 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver Date: Wed, 27 Aug 2014 11:38:43 -0700 Message-ID: <20140827183843.GC2198@roeck-us.net> References: <65074740dfc6363134384b45fcd3acf5f2b4254f.1409161615.git.andreas.werner@men.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-oa0-f49.google.com ([209.85.219.49]:36573 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbaH0Sir (ORCPT ); Wed, 27 Aug 2014 14:38:47 -0400 Content-Disposition: inline In-Reply-To: <65074740dfc6363134384b45fcd3acf5f2b4254f.1409161615.git.andreas.werner@men.de> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, lee.jones@linaro.org, lm-sensors@lm-sensors.org, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org On Wed, Aug 27, 2014 at 07:53:06PM +0200, Andreas Werner wrote: > Added driver to support the 14F021P00 BMC Hardware Monitoring. > The BMC is a Board Management Controller including monitoring of the > board voltages. > > Signed-off-by: Andreas Werner Looks good, though I do have one comment ... > + > + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, > + "menf21bmc", drv_data, > + menf21bmc_hwmon_groups); > + if (IS_ERR(hwmon_dev)) > + return PTR_ERR(hwmon_dev); > + > + dev_info(&pdev->dev, "MEN 14F021P00 BMC hwmon device enabled"); > + You removed the dev_info from the mfd driver but left it in the client drivers. If you'd drop it here as well, you could use 'return PTR_ERR_OR_ZERO(hwmon_dev);'. Just a suggestion, not mandatory. Either case, Reviewed-by: Guenter Roeck I assume this will go in through the mfd tree. Thanks, Guenter