From: Felipe Balbi <balbi@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michal Sojka <sojka@merica.cz>,
linux-usb@vger.kernel.org, Bryan Wu <cooloney@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
linux-kernel@vger.kernel.org, michal.vokac@comap.cz
Subject: Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity
Date: Wed, 27 Aug 2014 14:30:28 -0500 [thread overview]
Message-ID: <20140827193028.GK6347@saruman.home> (raw)
In-Reply-To: <20140827192751.GC9620@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Wed, Aug 27, 2014 at 12:27:51PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote:
> > With this patch, USB activity can be signaled by blinking a LED. There
> > are two triggers, one for activity on USB host and one for USB gadget.
> >
> > Both trigger should work with all host/device controllers. Tested only
> > with musb.
> >
> > Signed-off-by: Michal Sojka <sojka@merica.cz>
> > ---
> > drivers/usb/Kconfig | 11 ++++++
> > drivers/usb/common/Makefile | 5 ++-
> > drivers/usb/common/{usb-common.c => common.c} | 0
>
> I don't mind renaming files, but don't "hide" it in this patch, do it in
> a separate patch please, and then base your next patch on this one.
+1
yeah, this prevents us from reviewing the actual changes
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-27 19:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 11:53 [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity Michal Sojka
2014-08-22 11:53 ` [PATCH 2/2] leds: usb: Add LED trigger for USB host activity Michal Sojka
[not found] ` <1408708399-20423-1-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-08-22 17:39 ` [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity Bryan Wu
2014-08-22 21:42 ` Greg Kroah-Hartman
2014-08-22 23:41 ` Bryan Wu
2014-08-22 23:44 ` Michal Sojka
2014-08-22 21:59 ` Felipe Balbi
2014-08-22 23:54 ` Michal Sojka
2014-08-23 0:08 ` [PATCH v2 0/3] LED triggers for USB host and device Michal Sojka
2014-08-23 0:08 ` [PATCH v2 1/3] usb: Add missing #include Michal Sojka
2014-08-23 0:08 ` [PATCH v2 2/3] usb: Add LED trigger for USB host activity Michal Sojka
2014-08-23 0:30 ` Bryan Wu
2014-08-23 9:52 ` Michal Sojka
[not found] ` <87egw7a5yd.fsf-RBRde3N6TzKEyWgh05NgWw@public.gmane.org>
2014-08-25 18:59 ` Bryan Wu
2014-08-27 13:03 ` [PATCH v3 0/2] LED triggers for USB host and device Michal Sojka
2014-08-27 13:03 ` [PATCH v3 1/2] usb: gadget: Refactor request completion Michal Sojka
2014-08-27 13:43 ` Michal Sojka
2014-08-27 15:03 ` Alan Stern
[not found] ` <1409144625-25274-2-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-08-27 20:17 ` Felipe Balbi
2014-08-27 13:03 ` [PATCH v3 2/2] usb: Add LED triggers for USB activity Michal Sojka
2014-08-27 19:27 ` Greg Kroah-Hartman
2014-08-27 19:30 ` Felipe Balbi [this message]
2014-08-27 20:57 ` [PATCH v4 0/3] LED triggers for USB host and device Michal Sojka
2014-08-27 20:57 ` [PATCH v4 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-08-27 21:03 ` Alan Stern
2014-08-27 21:09 ` Greg Kroah-Hartman
2014-08-27 20:57 ` [PATCH v4 2/3] usb: Rename usb-common.c Michal Sojka
2014-08-27 20:58 ` [PATCH v4 3/3] usb: Add LED triggers for USB activity Michal Sojka
2014-08-27 21:08 ` Greg Kroah-Hartman
2014-08-29 12:57 ` Michal Sojka
2014-08-29 13:07 ` [PATCH v5 0/3] LED triggers for USB host and device Michal Sojka
2014-08-29 13:07 ` [PATCH v5 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-08-29 13:07 ` [PATCH v5 2/3] usb: Rename usb-common.c Michal Sojka
2014-08-29 13:07 ` [PATCH v5 3/3] usb: Add LED triggers for USB activity Michal Sojka
2014-08-23 0:08 ` [PATCH v2 3/3] usb: Add LED trigger for USB gadget activity Michal Sojka
2014-08-23 0:23 ` [PATCH v2 0/3] LED triggers for USB host and device Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827193028.GK6347@saruman.home \
--to=balbi@ti.com \
--cc=cooloney@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.vokac@comap.cz \
--cc=sojka@merica.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).