From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers Date: Tue, 9 Dec 2014 10:02:24 +0000 Message-ID: <20141209100224.GV3951@x1> References: <1417622814-10845-1-git-send-email-j.anaszewski@samsung.com> <1417622814-10845-4-git-send-email-j.anaszewski@samsung.com> <20141209085216.GS3951@x1> <5486BE6C.9010408@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:34718 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754197AbaLIKCb (ORCPT ); Tue, 9 Dec 2014 05:02:31 -0500 Received: by mail-ie0-f174.google.com with SMTP id rl12so176937iec.33 for ; Tue, 09 Dec 2014 02:02:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <5486BE6C.9010408@samsung.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, b.zolnierkie@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, Chanwoo Choi On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > On 12/09/2014 09:52 AM, Lee Jones wrote: > >On Wed, 03 Dec 2014, Jacek Anaszewski wrote: > > > >>Change flash cell identifiers from max77693-flash to max77693-led > >>to avoid confusion with NOR/NAND Flash. > >> > >>Signed-off-by: Jacek Anaszewski > >>Acked-by: Kyungmin Park > >>Cc: Chanwoo Choi > >>Cc: Lee Jones > >>--- > >> drivers/mfd/max77693.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >>diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > >>index a159593..cb14afa 100644 > >>--- a/drivers/mfd/max77693.c > >>+++ b/drivers/mfd/max77693.c > >>@@ -53,8 +53,8 @@ static const struct mfd_cell max77693_devs[] =3D = { > >> .of_compatible =3D "maxim,max77693-haptic", > >> }, > >> { > >>- .name =3D "max77693-flash", > >>- .of_compatible =3D "maxim,max77693-flash", > >>+ .name =3D "max77693-led", > >>+ .of_compatible =3D "maxim,max77693-led", > > > >This is fine by me, so long as you've been through the usual > >deprecation procedures or this platform is still WiP. >=20 > It was me who added of_compatible for max77693-flash, but the > related led driver has not been yet merged and there are no > other drivers depending on it. Very well. =46or my own reference: Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog