From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, b.zolnierkie@samsung.com,
cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi,
s.nawrocki@samsung.com
Subject: Re: [PATCH v2] Documentation: leds: Add description of LED Flash class extension
Date: Mon, 16 Feb 2015 20:45:15 +0100 [thread overview]
Message-ID: <20150216194515.GB13497@amd> (raw)
In-Reply-To: <54E1D218.6020000@samsung.com>
Hi!
> >root@duo:~# cat /sys/power/state
> >freeze mem disk
> >root@duo:~# cat /sys/power/disk
> >[platform] shutdown reboot suspend
> >root@duo:~#
> >
> >>Could you propose the acceptable format then?
> >>The numbers alone are inconvenient to use, we need a human
> >>readable description next to them. Or some another way
> >>to obtain the name.
> >
> >Files like "0.active", "0.name", "1.active", "1.name"?
> >
> >Subdirectories 0/1 with "name" and "active" files?
>
> We have flash_sync_strobe attribute which allows to read currently
> chosen sync_led. I would simplify this:
>
> Let's assume there are two LED Flash class deviecs:
>
> - max77693-flash1
> - max77693-flash2
>
> Proposed design described by use cases:
>
> #cd /sys/class/leds/max77693-flash1
> #cat available_flash_leds
> #[0.none] 1.max77693-flash2
Yeah. Should not have showed you /sys/power/state, right?
state gets away with this, because it uses few fixed strings. No funny
characters there, and it is "closely guarded". You don't have enough
control to do this... plus you have put the numbers there.
No.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2015-02-16 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 8:42 [PATCH v2] Documentation: leds: Add description of LED Flash class extension Jacek Anaszewski
2015-02-06 18:48 ` Bryan Wu
2015-02-09 8:17 ` Jacek Anaszewski
2015-02-11 21:57 ` Pavel Machek
2015-02-12 8:41 ` Jacek Anaszewski
2015-02-12 9:07 ` Pavel Machek
2015-02-12 10:10 ` Jacek Anaszewski
2015-02-12 10:54 ` Pavel Machek
2015-02-12 11:15 ` Jacek Anaszewski
2015-02-12 17:44 ` Pavel Machek
2015-02-16 11:18 ` Jacek Anaszewski
2015-02-16 13:06 ` Sakari Ailus
2015-02-16 13:30 ` Jacek Anaszewski
2015-02-16 19:45 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216194515.GB13497@amd \
--to=pavel@ucw.cz \
--cc=b.zolnierkie@samsung.com \
--cc=cooloney@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).