From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: linux-pwm@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Bryan Wu <cooloney@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/2] leds/pwm: Don't disable pwm when setting brightness to 0
Date: Wed, 25 Feb 2015 09:42:54 +0100 [thread overview]
Message-ID: <20150225084254.GI7789@pengutronix.de> (raw)
In-Reply-To: <54ED8426.6090401@i2se.com>
Hello Stefan,
On Wed, Feb 25, 2015 at 09:13:26AM +0100, Stefan Wahren wrote:
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Thanks.
> >> This is the functional part of this issue, since the warning has been fixed [1]
> > Can I interpret this as an Tested-by: for this patch and an Ack for
> > patch 1?
>
> Sorry, but i don't think i'm the right person for acking patch 1.
IMHO it doesn't matter who you are for an ack. You can consider it right
and tell it. How much this ack is useful to convince a maintainer to
take this patch is a different story.
But given that I try to fix the problem at hand for >2 years and I'm
stuck because Thierry isn't convinced that it's a correct way to go
forward but also doesn't come up with an alternative I'm happy about
everyone who gives his/her opinion. Still more if the opinion matches
mine.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-02-25 8:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 9:44 [PATCH 0/2] leds/pwm: don't call pwm_disable when setting brightness Uwe Kleine-König
2015-02-12 9:44 ` [PATCH 1/2] pwm/doc: Clearify that the pin state after pwm_disable is undefined Uwe Kleine-König
2015-02-12 9:44 ` [PATCH 2/2] leds/pwm: Don't disable pwm when setting brightness to 0 Uwe Kleine-König
2015-02-12 9:47 ` Uwe Kleine-König
2015-02-24 18:56 ` Stefan Wahren
2015-02-24 19:06 ` Uwe Kleine-König
2015-02-25 8:13 ` Stefan Wahren
2015-02-25 8:42 ` Uwe Kleine-König [this message]
2015-03-25 10:14 ` [PATCH 0/2] leds/pwm: don't call pwm_disable when setting brightness Uwe Kleine-König
2015-03-25 12:00 ` Thierry Reding
2015-03-27 8:59 ` Uwe Kleine-König
2015-03-27 11:26 ` Thierry Reding
2015-03-27 14:35 ` Uwe Kleine-König
2015-03-27 15:43 ` Thierry Reding
2015-03-27 18:49 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225084254.GI7789@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=cooloney@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=s.hauer@pengutronix.de \
--cc=stefan.wahren@i2se.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).