From: Sakari Ailus <sakari.ailus@iki.fi>
To: Ingi Kim <ingi2.kim@samsung.com>
Cc: cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
j.anaszewski@samsung.com, varkabhadram@gmail.com,
joe@perches.com, sw0312.kim@samsung.com, cw00.choi@samsung.com,
jh80.chung@samsung.com, ideal.song@samsung.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 3/3] leds: Add ktd2692 flash LED driver
Date: Fri, 10 Apr 2015 12:16:39 +0300 [thread overview]
Message-ID: <20150410091639.GG20756@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <55278DAA.40700@samsung.com>
Hi Ingi,
On Fri, Apr 10, 2015 at 05:45:30PM +0900, Ingi Kim wrote:
...
> >> + ret = devm_gpio_request_one(dev, led->ctrl_gpio,
> >> + GPIOF_OPEN_SOURCE, "ctrl-gpio");
> >
> > I think you could simply use devm_gpio_get(), and start using the new API
> > instead. It'd save quite a few lines of code, too.
> >
>
> did you mean devm_gpiod_get()
> Ok, I'll check it
Yes, that's what I meant.
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2015-04-10 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 6:45 [PATCH v6 0/3] Add ktd2692 Flash LED driver using LED Flash class Ingi Kim
2015-04-10 6:45 ` [PATCH v6 1/3] of: Add vendor prefix for Kinetic technologies Ingi Kim
2015-04-10 6:45 ` [PATCH v6 2/3] leds: ktd2692: add device tree bindings for ktd2692 Ingi Kim
2015-04-10 6:45 ` [PATCH v6 3/3] leds: Add ktd2692 flash LED driver Ingi Kim
2015-04-10 8:11 ` Sakari Ailus
2015-04-10 8:45 ` Ingi Kim
2015-04-10 9:16 ` Sakari Ailus [this message]
2015-04-10 6:59 ` [PATCH v6 0/3] Add ktd2692 Flash LED driver using LED Flash class Varka Bhadram
2015-04-10 7:17 ` Ingi Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410091639.GG20756@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=cooloney@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ideal.song@samsung.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ingi2.kim@samsung.com \
--cc=j.anaszewski@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sw0312.kim@samsung.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox