From: Andrew Lunn <andrew@lunn.ch>
To: Axel Lin <axel.lin@ingics.com>
Cc: Bryan Wu <cooloney@gmail.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check
Date: Sun, 26 Jul 2015 19:31:45 +0200 [thread overview]
Message-ID: <20150726173145.GI2385@lunn.ch> (raw)
In-Reply-To: <1437883516.7007.1.camel@ingics.com>
On Sun, Jul 26, 2015 at 12:05:16PM +0800, Axel Lin wrote:
> This checking is done by regmap_get_i2c_bus() which is called in
> devm_regmap_init_i2c().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/leds/leds-tlc591xx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
> index de16c29..b806eca 100644
> --- a/drivers/leds/leds-tlc591xx.c
> +++ b/drivers/leds/leds-tlc591xx.c
> @@ -231,10 +231,6 @@ tlc591xx_probe(struct i2c_client *client,
> if (!count || count > tlc591xx->max_leds)
> return -EINVAL;
>
> - if (!i2c_check_functionality(client->adapter,
> - I2C_FUNC_SMBUS_BYTE_DATA))
> - return -EIO;
> -
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> return -ENOMEM;
> --
> 2.1.0
>
>
>
next prev parent reply other threads:[~2015-07-26 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 4:05 [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check Axel Lin
2015-07-26 17:31 ` Andrew Lunn [this message]
2015-07-30 21:00 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726173145.GI2385@lunn.ch \
--to=andrew@lunn.ch \
--cc=axel.lin@ingics.com \
--cc=cooloney@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).