From: Vincent Pelletier <plr.vincent@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-leds@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: leds-gpio on x86
Date: Sat, 8 Aug 2015 14:06:56 +0200 [thread overview]
Message-ID: <20150808140656.6b81d3b9@x2> (raw)
In-Reply-To: <20150807105745.GB1540@lahna.fi.intel.com>
On Fri, 7 Aug 2015 13:57:45 +0300, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> Ah, this is different GPIO controller that is listed in the DSDT (the
> Baytrail GPIO host controller).
>
> In order to get ACPI GPIO stuff work here you would need to first add
> the GPIO device to the ACPI namespace and then modify gpio-f7188x.c to
> probe it from there. You would also need to invent a _HID to the device
> in order to get it matched. Unfortunately using random _HID will make
> upstreaming the changes difficult.
I gave a shot at writing a module. I got to the point where it builds
and loads, but it does not appear to do anything (no error
returned modprobe, nothing in dmesg).
I have no idea if the ~4 lines of "actual" code (ie, not just data
definition) are even in the good direction actually. I took
http://www.armadeus.com/wiki/index.php?title=GPIO_LEDS
as an example. This is for a platform definition for a devboard
(arm ?), so it may be a wrong example. I took a look at other led
drivers, and their complexity varies a lot.
Would you mind taking a look ?
https://github.com/vpelletier/linux/commits/ts651
For example, I have no idea how to explicitly depend on gpio-f7188x
and leds-gpio.
--
Vincent Pelletier
next prev parent reply other threads:[~2015-08-08 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 20:09 leds-gpio on x86 Vincent Pelletier
2015-08-06 16:59 ` Mika Westerberg
2015-08-06 17:17 ` Vincent Pelletier
2015-08-06 17:35 ` Mika Westerberg
2015-08-06 18:18 ` Vincent Pelletier
2015-08-07 10:57 ` Mika Westerberg
2015-08-08 12:06 ` Vincent Pelletier [this message]
2015-08-11 12:00 ` Mika Westerberg
2015-08-11 17:42 ` Vincent Pelletier
2015-08-12 12:53 ` Mika Westerberg
2015-08-15 10:36 ` Vincent Pelletier
2015-08-17 21:08 ` Vincent Pelletier
2015-08-18 7:32 ` Vincent Pelletier
2015-08-18 9:02 ` Mika Westerberg
2015-08-18 11:38 ` Vincent Pelletier
2015-08-18 22:56 ` Vincent Pelletier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150808140656.6b81d3b9@x2 \
--to=plr.vincent@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).