From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, sakari.ailus@linux.intel.com
Subject: Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting
Date: Fri, 9 Oct 2015 13:16:35 +0200 [thread overview]
Message-ID: <20151009111635.GA13923@amd> (raw)
In-Reply-To: <561775EC.80703@samsung.com>
On Fri 2015-10-09 10:08:12, Jacek Anaszewski wrote:
> On 10/09/2015 09:02 AM, Pavel Machek wrote:
> >On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
> >>On 10/08/2015 05:50 PM, Pavel Machek wrote:
> >>>On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> >>>>This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
> >>
> >>s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/
> >>
> >>>>led_set_brightness now calls led_set_brightness_nosleep instead of
> >>>>choosing between sync and async op basing on the flags defined by the
> >>>>driver.
> >>>
> >>>Are those flags unused in the version of kernel you are patching?
> >>
> >>The flags are used until this patch.
> >
> >Hmm. I seen you removing the definitions, but not removing any
> >users. I guess I missed something.
>
> Only LED core is the user. It sets SET_BRIGHTNESS_SYNC flag
> for LED flash class drivers.
Aha. All is right, then.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-10-09 11:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 14:29 [PATCH 0/5] LED flash: Set brightness in a sync way on demand Jacek Anaszewski
2015-09-21 14:29 ` [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-09-22 6:42 ` Sakari Ailus
2015-09-22 7:09 ` Jacek Anaszewski
2015-09-22 19:16 ` Andrew Lunn
2015-10-08 15:50 ` Pavel Machek
2015-10-09 6:28 ` Jacek Anaszewski
2015-10-09 7:02 ` Pavel Machek
2015-10-09 8:08 ` Jacek Anaszewski
2015-10-09 11:16 ` Pavel Machek [this message]
2015-09-21 14:29 ` [PATCH 2/5] Documentation: leds: Add description of brightness setting API Jacek Anaszewski
2015-09-22 10:26 ` Sakari Ailus
2015-09-22 11:03 ` Jacek Anaszewski
2015-09-22 19:27 ` Andrew Lunn
2015-09-23 9:24 ` Jacek Anaszewski
2015-09-21 14:29 ` [PATCH 3/5] leds: max77693: Remove work queue Jacek Anaszewski
2015-09-22 10:28 ` Sakari Ailus
2015-09-21 14:29 ` [PATCH 4/5] leds: aat1290: " Jacek Anaszewski
2015-09-21 14:29 ` [PATCH 5/5] leds: ktd2692: " Jacek Anaszewski
2015-10-08 15:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009111635.GA13923@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).