Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver

David Rivshin (Allworx)
2016-03-05T05:01:05Z

On Fri, 4 Mar 2016 22:14:27 +0100 (CET)
Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Hi David,
>
> > "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> hat am 3. März 2016 um
> > 04:01 geschrieben:
> >
> >
> > From: David Rivshin <drivshin@allworx.com>
> >
> > Si-En Technology was acquired by ISSI in 2011, and it appears that
> > the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices.
> > As the IS31FL32XX driver already handles the *3218 devices, there
> > is no longer a need for the dedicated SN3218 driver.
> >
> > Add the "sn,sn3218" and "sn,sn3216" compatible strings into the
> > IS31FL32XX driver and binding documentation, and remove the
> > leds-sn3218 driver.
> >
> > Datasheets:
> > IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf
> > SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf
> >
> > IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf
> > SN3216; http://www.si-en.com/uploadpdf/SN3216201152410148.pdf
> >
> > Signed-off-by: David Rivshin <drivshin@allworx.com>
>
> i tested this patch successfully with a Raspberry Pi and a PiGlow (SN3218).
>
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks very much for testing!

The PiGlow looks interesting, if I had known about it I might have just
ordered one for testing myself. Looks rather easier to hook up than the
ISSI 3216 eval board.