From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's Date: Fri, 1 Apr 2016 14:55:40 +0200 Message-ID: <20160401125540.GC11860@amd> References: <56D608ED.2090406@gmail.com> <20160329100258.GA24964@amd> <56FAE7A8.2070302@gmail.com> <20160329214323.GA10455@amd> <56FB893C.60203@samsung.com> <20160330130319.GB19994@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35107 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932390AbcDAMzn (ORCPT ); Fri, 1 Apr 2016 08:55:43 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Heiner Kallweit Cc: Jacek Anaszewski , pali.rohar@gmail.com, sre@kernel.org, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, Patrik Bachan , serge@hallyn.com, Greg KH , linux-leds@vger.kernel.org, Benjamin Tissoires , Linux Kernel Mailing List , Linux USB Mailing List Hi! > > pavel@duo:~$ ls -1 /sys/class/leds/ > > tpacpi:green:batt > > tpacpi:orange:batt > > > > This is physically 2 leds but hidden under one indicator, so you got > > "off", "green", "orange" and "green+orange". > > That's a good example. As long as you can recognize green+orange as > separate lights/colors > (w/o magnifying glass) I wouldn't call it "a LED with multiple colors" > but "multiple > LED devices". Well, that's how it is currently handled. But for the user, it looks as a LED with multiple colors. > In my use case we talk about RGB LEDs like the commonly used 5050 SMD RGB LEDs. > And it's not only about using a handful of discrete colors but about > displaying any arbitrary > color. > So far the kernel exposes the physical RGB LEDs as separate LEDs only > and I can't use > a trigger to e.g. set "magenta with 50% brightness". Why not? What do you do if you want to display magenta on your LCD? You compute RGB values, then display them. What would you do for the LEDs? Same thing. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html