From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 2/2] leds: trigger: Introduce a MTD (NAND/NOR) trigger Date: Tue, 12 Apr 2016 21:46:47 +0200 Message-ID: <20160412214647.1249e587@bbrezillon> References: <1460478395-25925-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1460478395-25925-3-git-send-email-ezequiel@vanguardiasur.com.ar> <20160412202732.30d291c2@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from down.free-electrons.com ([37.187.137.238]:46914 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756983AbcDLTqu (ORCPT ); Tue, 12 Apr 2016 15:46:50 -0400 In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Ezequiel Garcia Cc: "linux-mtd@lists.infradead.org" , Linux LED Subsystem , Brian Norris , Jacek Anaszewski On Tue, 12 Apr 2016 16:35:43 -0300 Ezequiel Garcia wrote: > On 12 April 2016 at 15:40, Ezequiel Garcia > wrote: > > On 12 April 2016 at 15:27, Boris Brezillon > > wrote: > >> Hi Ezequiel, > >> > >> On Tue, 12 Apr 2016 13:26:35 -0300 > >> Ezequiel Garcia wrote: > >> > >>> This commit introduces a MTD trigger for flash (NAND/NOR) device > >>> activity. The implementation is copied from IDE disk. > >>> > >>> This deprecates the "nand-disk" LED trigger, but for backwards > >>> compatibility, we still keep the "nand-disk" trigger around. > >>> > >>> The motivation for deprecating the "nand-disk" LED trigger is that > >>> it only works for NAND drivers, whereas the "mtd" LED trigger > >>> is more generic (in fact, "nand-disk" currently only works for > >>> certain NAND drivers). > >>> > >>> Signed-off-by: Ezequiel Garcia > >>> --- > >>> drivers/leds/trigger/Kconfig | 8 +++++++ > >>> drivers/leds/trigger/Makefile | 1 + > >>> drivers/leds/trigger/ledtrig-mtd.c | 49 ++++++++++++++++++++++++++++++++++++++ > >>> drivers/mtd/mtdcore.c | 7 ++++++ > >>> drivers/mtd/nand/nand_base.c | 29 +--------------------- > >>> include/linux/leds.h | 6 +++++ > >> > >> I'd suggest splitting this patch in 2, one adding ledtrig-mtd code, and > >> another one make use of ledtrig_mtd_activity() and removing > >> nand-trigger code. > >> > > > > Sure, that sounds good. > > > > One comment about the above: notice that if we split in two patches > as you suggest, we would create a dependency between patches. > > I don't have any problem doing this, but it sounds like it might make > maintainers > life harder. I guess both patches will go through the same tree even if they are split (either leds or mtd), so that's not really a problem. Note that you have the same dependency problem with the single patch approach (if another leds or mtd patch is touching one of the file modified here, we may have a merge conflict). -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com