* [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()
@ 2016-04-18 14:40 Jacek Anaszewski
2016-04-18 14:57 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2016-04-18 14:40 UTC (permalink / raw)
To: linux-leds
Cc: linux-kernel, rpurdie, boris.brezillon, ezequiel, pavel,
Jacek Anaszewski
Parameters delay_on and delay_off of led_trigger_blink_oneshot()
are pointers, to enable blink interval adjustment by LED class drivers
of the controllers that implement hardware blinking.
Move ide_blink_delay variable to ledtrig_ide_activity() in order to
prevent the situation when adjustment committed by one LED class
driver influences blink interval of the software fallback blink feature,
that is applied to the drivers that don't implement blink_set op.
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
drivers/leds/trigger/ledtrig-ide-disk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c
index c02a3ac..15123d3 100644
--- a/drivers/leds/trigger/ledtrig-ide-disk.c
+++ b/drivers/leds/trigger/ledtrig-ide-disk.c
@@ -18,10 +18,11 @@
#define BLINK_DELAY 30
DEFINE_LED_TRIGGER(ledtrig_ide);
-static unsigned long ide_blink_delay = BLINK_DELAY;
void ledtrig_ide_activity(void)
{
+ unsigned long ide_blink_delay = BLINK_DELAY;
+
led_trigger_blink_oneshot(ledtrig_ide,
&ide_blink_delay, &ide_blink_delay, 0);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()
2016-04-18 14:40 [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Jacek Anaszewski
@ 2016-04-18 14:57 ` Boris Brezillon
2016-04-19 7:09 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2016-04-18 14:57 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds, linux-kernel, rpurdie, ezequiel, pavel
On Mon, 18 Apr 2016 16:40:46 +0200
Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
> are pointers, to enable blink interval adjustment by LED class drivers
> of the controllers that implement hardware blinking.
>
> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
> prevent the situation when adjustment committed by one LED class
> driver influences blink interval of the software fallback blink feature,
> that is applied to the drivers that don't implement blink_set op.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/leds/trigger/ledtrig-ide-disk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c
> index c02a3ac..15123d3 100644
> --- a/drivers/leds/trigger/ledtrig-ide-disk.c
> +++ b/drivers/leds/trigger/ledtrig-ide-disk.c
> @@ -18,10 +18,11 @@
> #define BLINK_DELAY 30
>
> DEFINE_LED_TRIGGER(ledtrig_ide);
> -static unsigned long ide_blink_delay = BLINK_DELAY;
>
> void ledtrig_ide_activity(void)
> {
> + unsigned long ide_blink_delay = BLINK_DELAY;
> +
> led_trigger_blink_oneshot(ledtrig_ide,
> &ide_blink_delay, &ide_blink_delay, 0);
> }
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()
2016-04-18 14:57 ` Boris Brezillon
@ 2016-04-19 7:09 ` Jacek Anaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2016-04-19 7:09 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linux-leds, linux-kernel, rpurdie, ezequiel, pavel
Hi Boris,
Thanks for the review, patch applied.
Best regards,
Jacek Anaszewski
On 04/18/2016 04:57 PM, Boris Brezillon wrote:
> On Mon, 18 Apr 2016 16:40:46 +0200
> Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
>
>> Parameters delay_on and delay_off of led_trigger_blink_oneshot()
>> are pointers, to enable blink interval adjustment by LED class drivers
>> of the controllers that implement hardware blinking.
>>
>> Move ide_blink_delay variable to ledtrig_ide_activity() in order to
>> prevent the situation when adjustment committed by one LED class
>> driver influences blink interval of the software fallback blink feature,
>> that is applied to the drivers that don't implement blink_set op.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-19 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-18 14:40 [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Jacek Anaszewski
2016-04-18 14:57 ` Boris Brezillon
2016-04-19 7:09 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).