From: Olof Johansson <olof@lixom.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rhard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Duncan Laurie <dlaurie@chromium.org>,
Simon Que <sque@chromium.org>, Bryan Wu <cooloney@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
Evan McClain <aeroevan@gmail.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3] platform/chrome: Add Chrome OS keyboard backlight LEDs support
Date: Wed, 11 May 2016 10:57:55 -0700 [thread overview]
Message-ID: <20160511175755.GA21847@localhost> (raw)
In-Reply-To: <20160308191246.GA15630@dtor-ws>
On Tue, Mar 08, 2016 at 11:12:46AM -0800, Dmitry Torokhov wrote:
> This is a driver for ACPI-based keyboard backlight LEDs found on
> Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports
> backlight as "chromeos::kbd_backlight" LED class device in sysfs.
>
> Signed-off-by: Simon Que <sque@chromium.org>
> Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
> Tested-by: Evan McClain <aeroevan@gmail.com>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> ---
>
> Changes from previous submissions:
>
> v2->v3:
> - dropped call to platform_set_drvdata() as suggested by Guenter
>
> v1->v2:
> - moved from drivers/leds to drivers/platform/chrome
> - added method to retrieve brightness from ACPI
> - renamed to cros_kbd_led_backlight
> - config option renamed to CROS_KBD_LED_BACKLIGHT
> - no longer setting initial brightness to max brightness (although on
> Pixel 1 - Link - ACPI initially reports 100 as brightness anyway)
Ugh. I dropped the ball on this and other patches. Applied now.
-Olof
prev parent reply other threads:[~2016-05-11 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 19:12 [PATCH v3] platform/chrome: Add Chrome OS keyboard backlight LEDs support Dmitry Torokhov
2016-05-11 17:57 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511175755.GA21847@localhost \
--to=olof@lixom.net \
--cc=aeroevan@gmail.com \
--cc=cooloney@gmail.com \
--cc=dlaurie@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).