From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Tony Makkiel <tony.makkiel@daqri.com>,
linux-leds@vger.kernel.org, j.anaszewski@samsung.com,
rpurdie@rpsys.net
Subject: Re: [PATCH v5 1/1] leds: LED driver for TI LP3952 6-Channel Color LED
Date: Mon, 27 Jun 2016 10:53:22 +0300 [thread overview]
Message-ID: <20160627075322.GR1718@lahna.fi.intel.com> (raw)
In-Reply-To: <1833687.53qtq4DcBM@vostro.rjw.lan>
On Fri, Jun 24, 2016 at 03:51:14PM +0200, Rafael J. Wysocki wrote:
> > +#ifdef CONFIG_ACPI
> > +static const struct acpi_device_id lp3952_acpi_match[] = {
> > + {LP3952_NAME, 0},
>
> The above line is not necessary AFAICS. Mika?
Indeed, it should not be there.
> > + {LP3952_ACPI_NAME, 0},
> > + {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
> > +#endif
> > +
> > +static struct i2c_driver lp3952_i2c_driver = {
> > + .driver = {
> > + .name = LP3952_NAME,
> > + .owner = THIS_MODULE,
> > +#ifdef CONFIG_ACPI
> > + .acpi_match_table = ACPI_PTR(lp3952_acpi_match),
> > +#endif
Also this #ifdeffery is not needed either.
> > + },
> > + .probe = lp3952_probe,
> > + .remove = lp3952_remove,
> > + .id_table = lp3952_id,
> > +};
next prev parent reply other threads:[~2016-06-27 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 10:51 [PATCH v5 1/1] leds: LED driver for TI LP3952 6-Channel Color LED Tony Makkiel
2016-06-24 13:51 ` Rafael J. Wysocki
2016-06-24 14:17 ` Tony
2016-06-27 7:53 ` Mika Westerberg [this message]
2016-06-27 10:12 ` Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627075322.GR1718@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox