From: Amitesh Singh <singh.amitesh@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>,
Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org
Subject: [PATCH] leds: oneshot - Allow default delay to be passed as an argument
Date: Sat, 3 Sep 2016 14:33:35 +0530 [thread overview]
Message-ID: <20160903090331.GA15375@ami-desktop> (raw)
This patch facilates the blink delay to be passed as
an argument at the time of module loading.
e.g.
insmod ledtrigg-oneshot.ko default_delay=100
---
drivers/leds/trigger/ledtrig-oneshot.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/trigger/ledtrig-oneshot.c b/drivers/leds/trigger/ledtrig-oneshot.c
index b8ea9f0..95933a1 100644
--- a/drivers/leds/trigger/ledtrig-oneshot.c
+++ b/drivers/leds/trigger/ledtrig-oneshot.c
@@ -22,6 +22,9 @@
#define DEFAULT_DELAY 100
+static unsigned long default_delay = DEFAULT_DELAY;
+module_param(default_delay, ulong, S_IRUGO|S_IWUSR);
+
struct oneshot_trig_data {
unsigned int invert;
};
@@ -146,8 +149,8 @@ static void oneshot_trig_activate(struct led_classdev *led_cdev)
if (rc)
goto err_out_invert;
- led_cdev->blink_delay_on = DEFAULT_DELAY;
- led_cdev->blink_delay_off = DEFAULT_DELAY;
+ led_cdev->blink_delay_on = default_delay;
+ led_cdev->blink_delay_off = default_delay;
led_cdev->activated = true;
--
2.7.4
This patch facilates the blink delay to be passed as
an argument at the time of module loading.
e.g.
insmod ledtrigg-oneshot.ko default_delay=100
next reply other threads:[~2016-09-03 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 9:03 Amitesh Singh [this message]
2016-09-03 13:44 ` [PATCH] leds: oneshot - Allow default delay to be passed as an argument Jacek Anaszewski
2016-09-03 15:39 ` Amitesh Singh
[not found] ` <CABKcAmXSwgMbopurjrNU7fgPu58W-ZDbDi6VuUn2P2zOGATYLQ@mail.gmail.com>
2016-09-03 18:12 ` Jacek Anaszewski
2016-09-06 15:05 ` Amitesh Singh
2016-09-06 18:52 ` Jacek Anaszewski
-- strict thread matches above, loose matches on Subject: below --
2016-09-03 8:39 Amitesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160903090331.GA15375@ami-desktop \
--to=singh.amitesh@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).