* [PATCH] leds: triggers: Check return value of kobject_uevent_env()
@ 2016-09-19 8:22 Jacek Anaszewski
2016-09-19 8:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jacek Anaszewski @ 2016-09-19 8:22 UTC (permalink / raw)
To: linux-leds; +Cc: linux-kernel, greg, Jacek Anaszewski, Jacek Anaszewski
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Log error message if kobject_uevent_env() fails in led_trigger_set().
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
drivers/leds/led-triggers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..f538e8c 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,8 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
if (event) {
envp[0] = event;
envp[1] = NULL;
- kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
+ if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
+ pr_err("Error sending uevent after setting LED trigger\n");
kfree(event);
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: triggers: Check return value of kobject_uevent_env()
2016-09-19 8:22 [PATCH] leds: triggers: Check return value of kobject_uevent_env() Jacek Anaszewski
@ 2016-09-19 8:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-09-19 8:56 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds, linux-kernel, Jacek Anaszewski
On Mon, Sep 19, 2016 at 10:22:51AM +0200, Jacek Anaszewski wrote:
> From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>
> Log error message if kobject_uevent_env() fails in led_trigger_set().
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> ---
> drivers/leds/led-triggers.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index c7a38d4..f538e8c 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -141,7 +141,8 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
> if (event) {
> envp[0] = event;
> envp[1] = NULL;
> - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
> + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
> + pr_err("Error sending uevent after setting LED trigger\n");
You have a device, please use dev_err() for stuff like this, so that you
know what exact device caused the problem.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-19 8:22 [PATCH] leds: triggers: Check return value of kobject_uevent_env() Jacek Anaszewski
2016-09-19 8:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).