From: Zach Brown <zach.brown@ni.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
j.anaszewski@samsung.com, linux-leds@vger.kernel.org,
mlindner@marvell.com
Subject: Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace
Date: Tue, 11 Oct 2016 16:29:39 -0500 [thread overview]
Message-ID: <20161011212938.GA24636@zach-desktop> (raw)
In-Reply-To: <20161011141407.3b233e83@xeon-e3>
On Tue, Oct 11, 2016 at 02:14:07PM -0700, Stephen Hemminger wrote:
> On Tue, 11 Oct 2016 15:26:18 -0500
> Zach Brown <zach.brown@ni.com> wrote:
>
> > Adding led support for phy causes namespace conflicts for some
> > phy drivers.
> >
> > The marvel skge driver declared an enum for representing the states of
> > Link LED Register. The enum contained constant LED_OFF which conflicted
> > with declartation found in linux/leds.h.
> > LED_OFF changed to LED_REG_OFF
> > Also changed LED_ON to LED_REG_ON to avoid possible future conflict and
> > for consistency.
> >
> > Signed-off-by: Zach Brown <zach.brown@ni.com>
>
> Sure, that's fine but not sure why skge would be including linux/leds.h
> anyway.
It's pretty convoluted. Here's the chain of includes.
skge -> netdevice -> dsa -> phy -> phy_led_triggers -> leds
next prev parent reply other threads:[~2016-10-11 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 20:26 [PATCH v4 0/3] Add support for led triggers on phy link state change Zach Brown
2016-10-11 20:26 ` [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Zach Brown
2016-10-11 21:14 ` Stephen Hemminger
2016-10-11 21:29 ` Zach Brown [this message]
2016-10-11 20:26 ` [PATCH v4 2/3] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown
2016-10-11 20:26 ` [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change Zach Brown
2016-10-13 14:46 ` David Miller
2016-10-13 15:42 ` Zach Brown
2016-10-13 15:59 ` David Miller
2016-10-13 16:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011212938.GA24636@zach-desktop \
--to=zach.brown@ni.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrew@lunn.ch \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).