From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 0/2] Add led_notify_brightness_change led-core function and use in dell-wmi driver
Date: Wed, 19 Oct 2016 16:10:22 +0200 [thread overview]
Message-ID: <20161019141022.GG1689@pali> (raw)
In-Reply-To: <20161019133355.6192-1-hdegoede@redhat.com>
On Wednesday 19 October 2016 15:33:53 Hans de Goede wrote:
> Checking other sysfs drivers, there is a standard way to notify userspace
> about changes to a sysfs attributes underlying value. This patch-set adds
> a led_notify_brightness_change led-core function using this standard
> mechanism and makes the dell-wmi driver call led_notify_brightness_change
> on the kbd_backlight led_classdev when the firmware has changed the
> brightness. Together with some userspace changes / fixes this leads to
> a much nicer / more integrated experience wrt kbd backlight control.
Thank you for bringing this back! I had similar solution in my mind, but
I have not had time to implement it yet. It is great to see support for
this.
> Currently this patch-set introduces only 1 user (dell-wmi) of the new
> led_notify_brightness_change function, but I plan to also fix the same
> issue on thinkpads (soon),
Look at thinkpad acpi mailing list discussion. There is acpi information
how to listen for firmware event when keyboard backlight on thinkpad was
changed. Maybe it could help you...
--
Pali Rohár
pali.rohar@gmail.com
prev parent reply other threads:[~2016-10-19 14:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 13:33 [PATCH 0/2] Add led_notify_brightness_change led-core function and use in dell-wmi driver Hans de Goede
2016-10-19 13:33 ` [PATCH 1/2] leds: core: Add led_notify_brightness_change helper function Hans de Goede
2016-10-19 13:59 ` Pali Rohár
2016-10-19 16:07 ` Hans de Goede
2016-10-20 6:42 ` Jacek Anaszewski
2016-10-20 8:41 ` Hans de Goede
2016-10-20 9:15 ` Jacek Anaszewski
2016-10-20 10:02 ` Hans de Goede
2016-10-20 20:31 ` Jacek Anaszewski
2016-10-20 7:40 ` Pali Rohár
2016-10-19 13:33 ` [PATCH 2/2] platform: x86: dell-*: Call led_notify_brightness_change on kbd brightness change Hans de Goede
2016-10-19 14:06 ` Pali Rohár
2016-10-19 16:09 ` Hans de Goede
2016-10-20 7:48 ` Pali Rohár
2016-10-20 8:42 ` Hans de Goede
2016-10-19 14:10 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019141022.GG1689@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).