From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v5 2/6] leds: triggers: Add a keyboard backlight trigger Date: Mon, 21 Nov 2016 12:41:41 +0100 Message-ID: <20161121114140.GA5094@amd> References: <20161117222441.31464-1-hdegoede@redhat.com> <55cdf83d-2233-151f-08e1-11d4619e8fd5@redhat.com> <7b8252c4-bb2a-01dd-2404-9b81c192fb6a@gmail.com> <201611201605.17631@pali> <20161120162116.GA15737@amd> <0c4e7840-064c-5d8a-c5eb-8afe71727fcd@samsung.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Return-path: Content-Disposition: inline In-Reply-To: <0c4e7840-064c-5d8a-c5eb-8afe71727fcd@samsung.com> Sender: platform-driver-x86-owner@vger.kernel.org To: Jacek Anaszewski Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Jacek Anaszewski , Hans de Goede , Darren Hart , Matthew Garrett , Henrique de Moraes Holschuh , Richard Purdie , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>As pointed in other email, we do not know if HW really controls keyboar= d backlight, > >>so adding "fake" trigger on machines without HW control is not a good i= dea. > > > >Well, if we know that hardware will not change the brightness on its > >own, yes, I'd avoid the trigger. If we don't know (as is common on > >ACPI machines, I'd keep the trigger). >=20 > I'd drop the trigger approach due to the mess it can make in peoples' > minds due to the fact that LED class device handles trigger events > generated by itself. We can teach people. IMO the LED that changes itself is special, and trigger explains that nicely to the userspace. Plus, it allows us to keep this functionality out of the core.=20 > I'd add a file hw_brightness_change or async_brightness or something > similar and make it only readable/pollable. current_brightness is > ambiguous and questionable. Well, exact name is not too important... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlgy3XQACgkQMOfwapXb+vJDQACghBoyQnVEZiWY4MM0uo7ctkot 9ncAniyXPGpHiw15xhfKAg1jPWMw81d7 =8H7l -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--