[PATCH] leds: add LED_ON brightness as boolean value

[PATCH] leds: add LED_ON brightness as boolean value

[Andi Shyti]

Some devices do not handle the led brightness or simply don't
care about it. Conceptually said devices want to just switch on
or off the led. It is useless in this case to have a 255 range
of brightness, while just having an LED_ON and LED_OFF improves
the boolean meaning of the led status.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 include/linux/leds.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/leds.h b/include/linux/leds.h
index 569cb531094c..0258f9c49034 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -27,6 +27,7 @@ struct device;
 
 enum led_brightness {
 	LED_OFF		= 0,
+	LED_ON,
 	LED_HALF	= 127,
 	LED_FULL	= 255,
 };
-- 
2.11.0

Re: [PATCH] leds: add LED_ON brightness as boolean value

[Jacek Anaszewski]

Hi Andi,

Thanks for the patch.

On 01/04/2017 02:41 PM, Andi Shyti wrote:
> Some devices do not handle the led brightness or simply don't
> care about it. Conceptually said devices want to just switch on
> or off the led. It is useless in this case to have a 255 range
> of brightness, while just having an LED_ON and LED_OFF improves
> the boolean meaning of the led status.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
>  include/linux/leds.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 569cb531094c..0258f9c49034 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -27,6 +27,7 @@ struct device;
>  
>  enum led_brightness {
>  	LED_OFF		= 0,
> +	LED_ON,

Now lack of explicit value assignment to LED_ON looks weird
since it is surrounded by other initializer values.
I'd prefer to have "LED_ON = 1," in this line.

>  	LED_HALF	= 127,
>  	LED_FULL	= 255,
>  };
> 

-- 
Best regards,
Jacek Anaszewski

Re: [PATCH] leds: add LED_ON brightness as boolean value

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

Hi!

> > Some devices do not handle the led brightness or simply don't
> > care about it. Conceptually said devices want to just switch on
> > or off the led. It is useless in this case to have a 255 range
> > of brightness, while just having an LED_ON and LED_OFF improves
> > the boolean meaning of the led status.
> > 
> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> > ---
> >  include/linux/leds.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/leds.h b/include/linux/leds.h
> > index 569cb531094c..0258f9c49034 100644
> > --- a/include/linux/leds.h
> > +++ b/include/linux/leds.h
> > @@ -27,6 +27,7 @@ struct device;
> >  
> >  enum led_brightness {
> >  	LED_OFF		= 0,
> > +	LED_ON,
> 
> Now lack of explicit value assignment to LED_ON looks weird
> since it is surrounded by other initializer values.
> I'd prefer to have "LED_ON = 1," in this line.

Yes, please, good idea.

(Documentation already says on/off leds should use 0/1. Good.)

With "= 1" added for consistency,

Acked-by: Pavel Machek <pavel@ucw.cz>
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]