linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org
Subject: Re: LED devices & poll() for brightness attribute
Date: Thu, 23 Feb 2017 22:03:21 +0100	[thread overview]
Message-ID: <20170223210321.GB19376@amd> (raw)
In-Reply-To: <201702232144.54558@pali>

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]

Hi!

> > > > 2) there may be more then one
> > > 
> > > Yes and script can be adjusted to use specific one (config option
> > > for script).
> > 
> > No, you should autoconfigure it,
> 
> Why? Because you prefer autoconfiguration and all other people must use 
> it only? Does not seems a good argument.
> 
> For machine which does not change, static policy file is enough too. And 
> for this simple case it will work correctly.
> 
> Why everybody must be forced to use some autoconfiguration and does not 
> allow user to use his own manual configuration?

Why everybody must be forced to poll() on brightness file?

> > actually. See N900, there are 6 leds controlling one backlight.
> 
> I'm not saying that one script must be universal for everything. My 
> script is enough for machine with single keyboard led. And for other 
> people who have only one backlight keyboard it will work fine too.

> For other cases something other could be written...

For other cases, you need to communicate with the desktop.

> > And I don't want led/brightness file to be used for interprocess
> > communication.
> 
> You are not forced to use something. I'm proposing extending current ABI 
> which can be used for processes who want those notification.

Your proposal does not help you with your problem, unless you get
desktop people to poll() on the brightness files, and do something
inteligent with the results.

Hmm. And doing something inteligent will be quite hard given that we
have 6 of those files on N900.

So, if you seriously want to do this, can you

1) write specification explaining how desktops should poll() the
brightness files

2) get someone to volunteer to implement that specification for at
least GNOME and KDE?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-02-23 21:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  9:06 LED devices & poll() for brightness attribute Pali Rohár
2017-02-22 12:25 ` Pavel Machek
2017-02-22 12:39   ` Pali Rohár
2017-02-22 20:54     ` Pavel Machek
2017-02-22 21:16       ` Pali Rohár
2017-02-23 14:37         ` Pavel Machek
2017-02-23 14:48           ` Pali Rohár
2017-02-23 20:23             ` Pavel Machek
2017-02-23 20:44               ` Pali Rohár
2017-02-23 21:03                 ` Pavel Machek [this message]
2017-02-24  8:50                   ` Pali Rohár
2017-02-24  8:52                     ` Hans de Goede
2017-02-24  8:58                       ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223210321.GB19376@amd \
    --to=pavel@ucw.cz \
    --cc=dvhart@infradead.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).