From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH v8 1/7] platform/x86/thinkpad_acpi: Stop setting led_classdev brightness directly Date: Wed, 1 Mar 2017 12:27:00 +0100 Message-ID: <20170301112700.GD3185@pali> References: <20170209154417.19040-1-hdegoede@redhat.com> <20170209154417.19040-2-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170209154417.19040-2-hdegoede@redhat.com> Sender: platform-driver-x86-owner@vger.kernel.org To: Hans de Goede Cc: Darren Hart , Andy Shevchenko , Henrique de Moraes Holschuh , Jacek Anaszewski , Pavel Machek , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, Marco Trevisan List-Id: linux-leds@vger.kernel.org On Thursday 09 February 2017 16:44:11 Hans de Goede wrote: > There is no need to set the led_classdev's brightness value from > its set_brightness callback, this is taken care of by the led-core and > thinkpad_acpi really should not be mucking with it. > > Note that kbdlight_set_level_and_update() is still used by the old > thinpad_acpi specific sysfs interface for the led, so we cannot > remove it. > > Signed-off-by: Hans de Goede > --- > Changes in v8: > -New patch in v8 of this patch-set > --- > drivers/platform/x86/thinkpad_acpi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index cacb43f..0680bb3 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -5095,8 +5095,6 @@ static int kbdlight_set_level(int level) > return 0; > } > > -static int kbdlight_set_level_and_update(int level); > - > static int kbdlight_get_level(void) > { > int status = 0; > @@ -5164,7 +5162,7 @@ static void kbdlight_set_worker(struct work_struct *work) > container_of(work, struct tpacpi_led_classdev, work); > > if (likely(tpacpi_lifecycle == TPACPI_LIFE_RUNNING)) > - kbdlight_set_level_and_update(data->new_state); > + kbdlight_set_level(data->new_state); > } > > static void kbdlight_sysfs_set(struct led_classdev *led_cdev, Hi! This change was added in commit afcedebc6a0 (thinkpad_acpi: save kbdlight state on suspend and restore it on resume). It is really OK to revert that change? CCing Marco who is author of that commit. -- Pali Rohár pali.rohar@gmail.com