From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, Tony Makkiel <tony.makkiel@daqri.com>
Subject: Re: [PATCH v1] leds: lp3952: Remove ACPI support for lp3952
Date: Tue, 21 Mar 2017 21:17:40 +0100 [thread overview]
Message-ID: <20170321201739.GA20824@amd> (raw)
In-Reply-To: <20170321193315.33238-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
On Tue 2017-03-21 21:33:15, Andy Shevchenko wrote:
> In ACPI world any ID should be carefully chosen and registered
> officially. The discussion as I read it gets to wilful assignment an ID
> for non-existing real DSDT example.
>
> Rafael already told [2] how this device would be enumerated using
> compatible string.
>
> Based on above, remove non-official ACPI IDs and enumeration from the
> driver.
Hmm. Do any "real users" have hardware with TXNW3952 ACPI ID?
Pavel
> -static const struct acpi_device_id lp3952_acpi_match[] = {
> - {"TXNW3952", 0},
> - {}
> -};
> -
> -MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
> -#endif
> -
> static struct i2c_driver lp3952_i2c_driver = {
> .driver = {
> .name = LP3952_NAME,
> - .acpi_match_table = ACPI_PTR(lp3952_acpi_match),
> },
> .probe = lp3952_probe,
> .remove = lp3952_remove,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-03-21 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 19:33 [PATCH v1] leds: lp3952: Remove ACPI support for lp3952 Andy Shevchenko
2017-03-21 20:17 ` Pavel Machek [this message]
2017-03-22 13:15 ` Andy Shevchenko
[not found] ` <LO1P123MB0674648ED2956816983DC0C8C33C0@LO1P123MB0674.GBRP123.PROD.OUTLOOK.COM>
2017-03-22 14:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321201739.GA20824@amd \
--to=pavel@ucw.cz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).