From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: [PATCH v3 2/2] leds: lp3952: Use 'if (ret)' pattern Date: Thu, 23 Mar 2017 21:17:49 +0200 Message-ID: <20170323191749.26469-2-andriy.shevchenko@linux.intel.com> References: <20170323191749.26469-1-andriy.shevchenko@linux.intel.com> Return-path: Received: from mga04.intel.com ([192.55.52.120]:54380 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbdCWTRy (ORCPT ); Thu, 23 Mar 2017 15:17:54 -0400 In-Reply-To: <20170323191749.26469-1-andriy.shevchenko@linux.intel.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Richard Purdie , Jacek Anaszewski , Pavel Machek , linux-leds@vger.kernel.org Cc: Andy Shevchenko Instead of unusual "if (!ret)" use "if (ret)" in lp3952_get_label(). Signed-off-by: Andy Shevchenko --- drivers/leds/leds-lp3952.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-lp3952.c b/drivers/leds/leds-lp3952.c index 5184436b8905..847f7f282126 100644 --- a/drivers/leds/leds-lp3952.c +++ b/drivers/leds/leds-lp3952.c @@ -102,10 +102,11 @@ static int lp3952_get_label(struct device *dev, const char *label, char *dest) const char *str; ret = device_property_read_string(dev, label, &str); - if (!ret) - strncpy(dest, str, LP3952_LABEL_MAX_LEN); + if (ret) + return ret; - return ret; + strncpy(dest, str, LP3952_LABEL_MAX_LEN); + return 0; } static int lp3952_register_led_classdev(struct lp3952_led_array *priv) -- 2.11.0