From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCHv3 1/2] mfd: cpcap: Add missing include dependencies Date: Tue, 28 Mar 2017 09:16:33 +0100 Message-ID: <20170328081633.dgt6b6nnomkluxre@dell> References: <20170324084732.31255-1-sre@kernel.org> <20170327142608.qcobnqrvyu7u4ybz@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f182.google.com ([209.85.128.182]:35350 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754664AbdC1IRJ (ORCPT ); Tue, 28 Mar 2017 04:17:09 -0400 Received: by mail-wr0-f182.google.com with SMTP id u1so92076183wra.2 for ; Tue, 28 Mar 2017 01:17:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: Sebastian Reichel , Richard Purdie , Pavel Machek , Tony Lindgren , Rob Herring , Mark Rutland , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 27 Mar 2017, Jacek Anaszewski wrote: > On 03/27/2017 04:26 PM, Lee Jones wrote: > > On Fri, 24 Mar 2017, Jacek Anaszewski wrote: > >> On 03/24/2017 09:47 AM, Sebastian Reichel wrote: > >>> This fixes compilation for files, that try to include the > >>> cpcap header in alphabetically sorted #include lists. > >>> > >>> Acked-by: Pavel Machek > >>> Acked-by: Tony Lindgren > >>> Signed-off-by: Sebastian Reichel > >>> --- > >>> Changes since PATCHv2: > >>> - Add Acked-by from Tony & Pavel > >>> --- > >>> include/linux/mfd/motorola-cpcap.h | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h > >>> index 793aa695faa0..aefc49cb7ba9 100644 > >>> --- a/include/linux/mfd/motorola-cpcap.h > >>> +++ b/include/linux/mfd/motorola-cpcap.h > >>> @@ -14,6 +14,9 @@ > >>> * published by the Free Software Foundation. > >>> */ > >>> > >>> +#include > >>> +#include > >>> + > >>> #define CPCAP_VENDOR_ST 0 > >>> #define CPCAP_VENDOR_TI 1 > >> > >> Both patches applied to the for-next branch of linux-leds.git, thanks. > > > > Que? > > Ah, sorry, for some reason I silently assumed that Tony gave ack on > your behalf :-) Probably due to lack of your activity in the subject > and Tony's understanding thereof [0]. Right, but you still need to align with other Maintainers despite expert reviews, since they are in a better position to help avoid potential merge conflicts. > Can I have your ack for this patch going through LED tree then? I've gone one better and provided you with a pull-request. It's the best way to avoid merge conflict, subsequently upsetting the Big Penguin. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog