From: Pavel Machek <pavel@ucw.cz>
To: Wu Fenglin <fenglinw@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
'Richard Purdie' <rpurdie@rpsys.net>,
'Jacek Anaszewski' <jacek.anaszewski@gmail.com>,
'Rob Herring' <robh+dt@kernel.org>,
'Mark Rutland' <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
subbaram@quicinc.com, aghayal@qti.qualcomm.com,
wruan@quicinc.com, kgunda@qti.qualcomm.com
Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module
Date: Wed, 31 May 2017 18:55:40 +0200 [thread overview]
Message-ID: <20170531165540.GA9371@amd> (raw)
In-Reply-To: <001301d2d9e7$3102b720$93082560$@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Hi!
> Thanks for the reviewing.
>
> For the order, the hardware register mapping has this order (blue/green/red)
> from bit0/1/2, I can revert it to (red/green/blue) if there is a strong
> concern.
I'd do that.
> For these two properties: qcom,off-ms/ qcom,on-ms, I am using them to assign
> the default blinking on/off time, then the LEDs would have a default
> blinking pattern if you do "echo 1 > /sys/class/leds/red/blink"
Normally, dts describes hardware; this does not seem to be hardware
description, so I'd leave it out.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-05-31 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170531061541.10808-1-fenglinw@codeaurora.org>
2017-05-31 6:14 ` [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module fenglinw
[not found] ` <20170531061541.10808-2-fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-05-31 7:55 ` Pavel Machek
2017-05-31 8:23 ` Wu Fenglin
2017-05-31 16:55 ` Pavel Machek [this message]
2017-06-01 0:30 ` Wu Fenglin
2017-06-01 19:31 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531165540.GA9371@amd \
--to=pavel@ucw.cz \
--cc=aghayal@qti.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=fenglinw@codeaurora.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kgunda@qti.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=subbaram@quicinc.com \
--cc=wruan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).