From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro Date: Tue, 11 Jul 2017 17:31:57 +0200 Message-ID: <20170711153156.GA7269@amd> References: <20170711151533.GA15670@lynnl.yet> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54253 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932598AbdGKPcA (ORCPT ); Tue, 11 Jul 2017 11:32:00 -0400 Content-Disposition: inline In-Reply-To: <20170711151533.GA15670@lynnl.yet> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Lynn Lei Cc: rpurdie@rpsys.net, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2017-07-11 23:21:01, Lynn Lei wrote: > Fixed the unenclosed complex values macro issue generated by > scripts/checkpatch.pl: > ERROR: Macros with complex values should be enclosed in parentheses >=20 > Signed-off-by: Lynn Lei That's very very very stupid, right? Please don't do random checkpatch cleanups, be careful and test your change= s. NAK. Pavel > --- > drivers/leds/leds-aat1290.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c > index a21e19297745..061e2cfd8097 100644 > --- a/drivers/leds/leds-aat1290.c > +++ b/drivers/leds/leds-aat1290.c > @@ -35,7 +35,7 @@ > #define AAT1290_MM_CURRENT_RATIO_ADDR 20 > #define AAT1290_MM_TO_FL_1_92 1 > =20 > -#define AAT1290_MM_TO_FL_RATIO 1000 / 1920 > +#define AAT1290_MM_TO_FL_RATIO (1000 / 1920) > #define AAT1290_MAX_MM_CURRENT(fl_max) (fl_max * AAT1290_MM_TO_FL_RATIO) > =20 > #define AAT1290_LATCH_TIME_MIN_US 500 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllk72wACgkQMOfwapXb+vLFKQCglISdjeLxyAu5yRJEWj7PeZxa QG8AoLCnn7rIVMX2z9oN18afuV3Qv749 =KHyj -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--