From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-leds@vger.kernel.org,
jacek.anaszewski@gmail.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 2/2] v4l2-flash-led-class: Create separate sub-devices for indicators
Date: Wed, 19 Jul 2017 14:02:46 +0200 [thread overview]
Message-ID: <20170719120246.GB23510@amd> (raw)
In-Reply-To: <20170718184107.10598-3-sakari.ailus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Tue 2017-07-18 21:41:07, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED specific associations. Essentially, the original assumption of a
> LED driver chip that drives a single flash LED and an indicator LED is no
> longer valid.
>
> Address the matter by registering one sub-device per LED.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Does anything need to be done with drivers/media/i2c/adp1653.c ?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-07-19 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 18:41 [PATCH 0/2] Create sub-device per LED Sakari Ailus
2017-07-18 18:41 ` [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain Sakari Ailus
2017-07-19 11:59 ` Pavel Machek
2017-07-19 22:40 ` [PATCH 1/1] v4l2-flash-led-class: Document v4l2_flash_init() references Sakari Ailus
2017-07-20 6:50 ` Pavel Machek
2017-07-25 12:30 ` [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain Johan Hovold
2017-07-26 15:03 ` Rui Miguel Silva
2017-07-26 18:32 ` Pavel Machek
2017-07-27 13:59 ` Rui Miguel Silva
2017-07-18 18:41 ` [PATCH 2/2] v4l2-flash-led-class: Create separate sub-devices for indicators Sakari Ailus
2017-07-18 19:35 ` Jacek Anaszewski
2017-07-19 12:02 ` Pavel Machek [this message]
2017-07-19 22:42 ` Sakari Ailus
2017-08-07 22:45 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719120246.GB23510@amd \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).